Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel

2016-01-06 Thread Simon Wood
On Wed, January 6, 2016 6:47 pm, Dmitry Torokhov wrote: > It is wrong. Aside form the fact that IMO xpad.c is the wrong place for > this code to be in, why are we waiting for the input device to be opened by > userspace before we do the switch instead of doing it immediately? The 'send magic' mig

Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel

2016-01-06 Thread Dmitry Torokhov
On Wed, Jan 06, 2016 at 03:36:57PM +0100, Jiri Kosina wrote: > On Mon, 4 Jan 2016, Benjamin Tissoires wrote: > > > Jiri, I *think* this commit still is in your next pull request for > > Linus. We might want to drop it before it hits Linus' tree. > > What exactly would be the reasoning for droppin

Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel

2016-01-06 Thread Jiri Kosina
On Mon, 4 Jan 2016, Benjamin Tissoires wrote: > Jiri, I *think* this commit still is in your next pull request for > Linus. We might want to drop it before it hits Linus' tree. What exactly would be the reasoning for dropping it? I am all for implementing the skeleton HID driver to take over the

Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel

2016-01-04 Thread Dmitry Torokhov
Hi Simon, On Mon, Jan 04, 2016 at 01:05:35PM -0700, Simon Wood wrote: > > On Mon, 4 Jan 2016 02:55:24 -0700, Benjamin Tissoires wrote: > your next pull request for > > Linus. We might want to drop it before it hits Linus' tree. > > > > We can still keep the HID work in place even if the device i

Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel

2016-01-04 Thread madcatxster
On Mon Jan 4 10:55:24 2016 GMT+0100, Benjamin Tissoires wrote: > On Dec 10 2015 or thereabouts, Dmitry Torokhov wrote: > > On Thu, Dec 10, 2015 at 9:08 AM, Benjamin Tissoires > > wrote: > > > On Dec 09 2015 or thereabouts, Dmitry Torokhov wrote: > > >> On Wed, Dec 9, 2015 at 5:23 PM, Dmitry Toro

Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel

2016-01-04 Thread Benjamin Tissoires
On Dec 10 2015 or thereabouts, Dmitry Torokhov wrote: > On Thu, Dec 10, 2015 at 9:08 AM, Benjamin Tissoires > wrote: > > On Dec 09 2015 or thereabouts, Dmitry Torokhov wrote: > >> On Wed, Dec 9, 2015 at 5:23 PM, Dmitry Torokhov > >> wrote: > >> > On Thu, Nov 19, 2015 at 10:31 AM, Dmitry Torokhov

Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel

2015-12-13 Thread Elias Vanderstuyft
On Thu, Dec 10, 2015 at 6:08 PM, Benjamin Tissoires wrote: > On Dec 09 2015 or thereabouts, Dmitry Torokhov wrote: >> On Wed, Dec 9, 2015 at 5:23 PM, Dmitry Torokhov >> wrote: >> > On Thu, Nov 19, 2015 at 10:31 AM, Dmitry Torokhov >> > wrote: >> >> On Thu, Nov 19, 2015 at 02:50:51PM +0100, Jiri

Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel

2015-12-10 Thread Dmitry Torokhov
On Thu, Dec 10, 2015 at 9:08 AM, Benjamin Tissoires wrote: > On Dec 09 2015 or thereabouts, Dmitry Torokhov wrote: >> On Wed, Dec 9, 2015 at 5:23 PM, Dmitry Torokhov >> wrote: >> > On Thu, Nov 19, 2015 at 10:31 AM, Dmitry Torokhov >> > wrote: >> >> On Thu, Nov 19, 2015 at 02:50:51PM +0100, Jiri

Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel

2015-12-10 Thread Benjamin Tissoires
On Dec 09 2015 or thereabouts, Dmitry Torokhov wrote: > On Wed, Dec 9, 2015 at 5:23 PM, Dmitry Torokhov > wrote: > > On Thu, Nov 19, 2015 at 10:31 AM, Dmitry Torokhov > > wrote: > >> On Thu, Nov 19, 2015 at 02:50:51PM +0100, Jiri Kosina wrote: > >>> On Thu, 12 Nov 2015, Simon Wood wrote: > >>> >

Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel

2015-12-09 Thread Dmitry Torokhov
On Wed, Dec 9, 2015 at 5:23 PM, Dmitry Torokhov wrote: > On Thu, Nov 19, 2015 at 10:31 AM, Dmitry Torokhov > wrote: >> On Thu, Nov 19, 2015 at 02:50:51PM +0100, Jiri Kosina wrote: >>> On Thu, 12 Nov 2015, Simon Wood wrote: >>> >>> > When plugged in the Logitech G920 wheel starts with USBID 046d:c

Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel

2015-12-09 Thread Dmitry Torokhov
On Thu, Nov 19, 2015 at 10:31 AM, Dmitry Torokhov wrote: > On Thu, Nov 19, 2015 at 02:50:51PM +0100, Jiri Kosina wrote: >> On Thu, 12 Nov 2015, Simon Wood wrote: >> >> > When plugged in the Logitech G920 wheel starts with USBID 046d:c261 >> > and behaviors as a vendor specific class. If a 'magic'

Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel

2015-11-19 Thread Edwin
On 19-11-15 19:35, Simon Wood wrote: On Thu, November 19, 2015 11:31 am, Dmitry Torokhov wrote: > On Thu, Nov 19, 2015 at 02:50:51PM +0100, Jiri Kosina wrote: > >> On Thu, 12 Nov 2015, Simon Wood wrote: >> >> >>> When plugged in the Logitech G920 wheel starts with USBID 046d:c261 >>> and behavior

Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel

2015-11-19 Thread Simon Wood
On Thu, November 19, 2015 11:31 am, Dmitry Torokhov wrote: > On Thu, Nov 19, 2015 at 02:50:51PM +0100, Jiri Kosina wrote: > >> On Thu, 12 Nov 2015, Simon Wood wrote: >> >> >>> When plugged in the Logitech G920 wheel starts with USBID 046d:c261 >>> and behaviors as a vendor specific class. If a 'mag

Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel

2015-11-19 Thread Dmitry Torokhov
On Thu, Nov 19, 2015 at 02:50:51PM +0100, Jiri Kosina wrote: > On Thu, 12 Nov 2015, Simon Wood wrote: > > > When plugged in the Logitech G920 wheel starts with USBID 046d:c261 > > and behaviors as a vendor specific class. If a 'magic' byte sequence > > is sent the wheel will detach and reconnect a

Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel

2015-11-19 Thread Jiri Kosina
On Thu, 12 Nov 2015, Simon Wood wrote: > When plugged in the Logitech G920 wheel starts with USBID 046d:c261 > and behaviors as a vendor specific class. If a 'magic' byte sequence > is sent the wheel will detach and reconnect as a HID device with the > USBID 046d:c262. > > Signed-off-by: Simon Wo