Re: [Patch v3 1/2] kaslr: check if kernel location is changed

2014-09-12 Thread Kees Cook
On Fri, Sep 12, 2014 at 8:33 AM, Vivek Goyal wrote: > On Fri, Sep 12, 2014 at 11:22:44PM +0800, Baoquan He wrote: >> Function handle_relocations() is used to do the relocations handling >> for i686 and kaslr of x86_64. For 32 bit the relocation handling is >> mandotary to perform. For x86_64 only

Re: [Patch v3 1/2] kaslr: check if kernel location is changed

2014-09-12 Thread Thomas D.
Hi, Vivek Goyal wrote: > You had reported kexec issues with CONFIG_RANDOMIZE_BASE=y. Does this > patch resolve the issue for you? Yup! Tested against kernel-3.16.2. -Thomas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.ker

Re: [Patch v3 1/2] kaslr: check if kernel location is changed

2014-09-12 Thread Vivek Goyal
On Fri, Sep 12, 2014 at 05:56:12PM +0200, Thomas D. wrote: > Hi, > > Vivek Goyal wrote: > > You had reported kexec issues with CONFIG_RANDOMIZE_BASE=y. Does this > > patch resolve the issue for you? > > Yup! Tested against kernel-3.16.2. Thanks. Given this patch is small and should not break any

Re: [Patch v3 1/2] kaslr: check if kernel location is changed

2014-09-12 Thread Vivek Goyal
On Fri, Sep 12, 2014 at 11:22:44PM +0800, Baoquan He wrote: > Function handle_relocations() is used to do the relocations handling > for i686 and kaslr of x86_64. For 32 bit the relocation handling is > mandotary to perform. For x86_64 only when kaslr is enabled and a > random kernel location is ch