Re: [Patch v4 08/12] memory-hotplug: remove memmap of sparse-vmemmap

2012-12-06 Thread Jianguo Wu
Hi Tang, On 2012/12/7 9:42, Tang Chen wrote: > Hi Wu, > > I met some problems when I was digging into the code. It's very > kind of you if you could help me with that. :) > > If I misunderstood your code, please tell me. > Please see below. :) > > On 12/03/2012 10:23 AM, Jianguo Wu wrote: >> S

Re: [Patch v4 08/12] memory-hotplug: remove memmap of sparse-vmemmap

2012-12-06 Thread Tang Chen
Hi Wu, I met some problems when I was digging into the code. It's very kind of you if you could help me with that. :) If I misunderstood your code, please tell me. Please see below. :) On 12/03/2012 10:23 AM, Jianguo Wu wrote: Signed-off-by: Jianguo Wu Signed-off-by: Jiang Liu --- include/li

Re: [Patch v4 08/12] memory-hotplug: remove memmap of sparse-vmemmap

2012-12-04 Thread Jianguo Wu
Hi Tang, On 2012/12/5 10:07, Tang Chen wrote: > Hi Wu, > > On 12/04/2012 08:20 PM, Jianguo Wu wrote: > (snip) >>> >>> Seems that we have different ways to handle pages allocated by bootmem >>> or by regular allocator. Is the checking way in [PATCH 09/12] available >>> here ? >>> >>> +/* boot

Re: [Patch v4 08/12] memory-hotplug: remove memmap of sparse-vmemmap

2012-12-04 Thread Tang Chen
Hi Wu, On 12/04/2012 08:20 PM, Jianguo Wu wrote: (snip) Seems that we have different ways to handle pages allocated by bootmem or by regular allocator. Is the checking way in [PATCH 09/12] available here ? +/* bootmem page has reserved flag */ +if (PageReserved(page)) { .. +}

Re: [Patch v4 08/12] memory-hotplug: remove memmap of sparse-vmemmap

2012-12-04 Thread Jianguo Wu
Hi Tang, Thanks for your review and comments, Please see below for my reply. On 2012/12/4 17:13, Tang Chen wrote: > Hi Wu, > > Sorry to make noise here. Please see below. :) > > On 12/03/2012 10:23 AM, Jianguo Wu wrote: >> Signed-off-by: Jianguo Wu >> Signed-off-by: Jiang Liu >> --- >> inclu

Re: [Patch v4 08/12] memory-hotplug: remove memmap of sparse-vmemmap

2012-12-04 Thread Tang Chen
On 11/27/2012 06:00 PM, Wen Congyang wrote: static int __remove_section(struct zone *zone, struct mem_section *ms) { unsigned long flags; @@ -330,9 +317,9 @@ static int __remove_section(struct zone *zone, struct mem_section *ms) pgdat_resize_lock(pgdat,&flags); sparse

Re: [Patch v4 08/12] memory-hotplug: remove memmap of sparse-vmemmap

2012-12-04 Thread Tang Chen
Hi Wu, Sorry to make noise here. Please see below. :) On 12/03/2012 10:23 AM, Jianguo Wu wrote: Signed-off-by: Jianguo Wu Signed-off-by: Jiang Liu --- include/linux/mm.h |1 + mm/sparse-vmemmap.c | 231 +++ mm/sparse.c |3 +-

Re: [Patch v4 08/12] memory-hotplug: remove memmap of sparse-vmemmap

2012-12-02 Thread Jianguo Wu
Hi Congyang, This is the new version. Thanks, Jianguo Wu. Signed-off-by: Jianguo Wu Signed-off-by: Jiang Liu --- include/linux/mm.h |1 + mm/sparse-vmemmap.c | 231 +++ mm/sparse.c |3 +- 3 files changed, 234 insertions(+), 1

Re: [Patch v4 08/12] memory-hotplug: remove memmap of sparse-vmemmap

2012-11-29 Thread Yasuaki Ishimatsu
Hi Jianguo, 2012/11/30 11:47, Jianguo Wu wrote: Hi Congyang, Thanks for your review and comments. On 2012/11/30 9:45, Wen Congyang wrote: At 11/28/2012 05:40 PM, Jianguo Wu Wrote: Hi Congyang, I think vmemmap's pgtable pages should be freed after all entries are cleared, I have a patch to

Re: [Patch v4 08/12] memory-hotplug: remove memmap of sparse-vmemmap

2012-11-29 Thread Jianguo Wu
Hi Congyang, Thanks for your review and comments. On 2012/11/30 9:45, Wen Congyang wrote: > At 11/28/2012 05:40 PM, Jianguo Wu Wrote: >> Hi Congyang, >> >> I think vmemmap's pgtable pages should be freed after all entries are >> cleared, I have a patch to do this. >> The code logic is the same

Re: [Patch v4 08/12] memory-hotplug: remove memmap of sparse-vmemmap

2012-11-29 Thread Wen Congyang
At 11/28/2012 05:40 PM, Jianguo Wu Wrote: > Hi Congyang, > > I think vmemmap's pgtable pages should be freed after all entries are > cleared, I have a patch to do this. > The code logic is the same as [Patch v4 09/12] memory-hotplug: remove page > table of x86_64 architecture. > > How do you th

Re: [Patch v4 08/12] memory-hotplug: remove memmap of sparse-vmemmap

2012-11-28 Thread Jianguo Wu
Hi Congyang, I think vmemmap's pgtable pages should be freed after all entries are cleared, I have a patch to do this. The code logic is the same as [Patch v4 09/12] memory-hotplug: remove page table of x86_64 architecture. How do you think about this? Signed-off-by: Jianguo Wu Signed-off-by: