I'm agnostic on the change... As long as we get a message somewhere
when the failure is meaningful, I'm fine with this change. I didn't
like setting mwi by the driver anyway - it should have already been
done by the platform.
-- james s
Randy Dunlap wrote:
--- a/drivers/scsi/lpfc/lpfc_init.c
+
On Wed, 11 Jul 2007 17:37:31 -0700 Greg KH wrote:
> On Wed, Jul 11, 2007 at 06:01:49PM -0600, Matthew Wilcox wrote:
> > On Wed, Jul 11, 2007 at 04:31:40PM -0700, Greg Kroah-Hartman wrote:
> > > As suggested by Andrew, add pci_try_set_mwi(), which does not require
> > > return-value checking.
> >
On Wed, 11 Jul 2007 17:37:31 -0700 Greg KH wrote:
> On Wed, Jul 11, 2007 at 06:01:49PM -0600, Matthew Wilcox wrote:
> > On Wed, Jul 11, 2007 at 04:31:40PM -0700, Greg Kroah-Hartman wrote:
> > > As suggested by Andrew, add pci_try_set_mwi(), which does not require
> > > return-value checking.
> >
On Wed, Jul 11, 2007 at 06:01:49PM -0600, Matthew Wilcox wrote:
> On Wed, Jul 11, 2007 at 04:31:40PM -0700, Greg Kroah-Hartman wrote:
> > As suggested by Andrew, add pci_try_set_mwi(), which does not require
> > return-value checking.
>
> Seems like a daft suggestion. What's wrong with just remov
On Wed, Jul 11, 2007 at 04:31:40PM -0700, Greg Kroah-Hartman wrote:
> As suggested by Andrew, add pci_try_set_mwi(), which does not require
> return-value checking.
Seems like a daft suggestion. What's wrong with just removing the
__must_check from pci_set_mwi()? Did it find any bugs?
> --- a/d
5 matches
Mail list logo
