Re: [REGRESSION] usb: gadget: f_fs: Allow scatter-gather buffers

2019-05-21 Thread John Stultz
On Tue, May 21, 2019 at 3:04 AM Andrzej Pietrasiewicz wrote: > > One thing that becomes evident now is that adb uses async io. > It seems that interaction of async io and s-g mode should be further > investigated. Although on our devices, we have async io disabled w/ adb, as there is an existing/

Re: [REGRESSION] usb: gadget: f_fs: Allow scatter-gather buffers

2019-05-21 Thread Andrzej Pietrasiewicz
Hi, W dniu 20.05.2019 o 23:52, Yang, Fei pisze: One question that comes to my mind is this: Does the USB One of the problems appears to be that req->num_mapped_sgs was left uninitialized. I made the following change and got a lot more requests completed. However this change is not suffici

RE: [REGRESSION] usb: gadget: f_fs: Allow scatter-gather buffers

2019-05-20 Thread Yang, Fei
One question that comes to my mind is this: Does the USB transmission stall (e.g. endpoint stall) or not? In other words, is adb connection broken because USB stops transmitting anything, or because the data is transmitted but its integrity is broken during transmission

Re: [REGRESSION] usb: gadget: f_fs: Allow scatter-gather buffers

2019-05-20 Thread John Stultz
On Mon, May 20, 2019 at 9:23 AM Yang, Fei wrote: > > >> One question that comes to my mind is this: Does the USB transmission > >> stall (e.g. endpoint stall) or not? In other words, is adb connection > >> broken because USB stops transmitting anything, or because the data is > >> transmitted but

RE: [REGRESSION] usb: gadget: f_fs: Allow scatter-gather buffers

2019-05-20 Thread Yang, Fei
>> One question that comes to my mind is this: Does the USB transmission >> stall (e.g. endpoint stall) or not? In other words, is adb connection >> broken because USB stops transmitting anything, or because the data is >> transmitted but its integrity is broken during transmission and that >>

Re: [REGRESSION] usb: gadget: f_fs: Allow scatter-gather buffers

2019-05-20 Thread Andrzej Pietrasiewicz
Hi John, Is there anything else I can try for you? Have you tried compiling FunctionFS with debugging enabled? You do so bu uncommenting: /* #define DEBUG */ /* #define VERBOSE_DEBUG */ at the beginning of drivers/usb/gadget/function/f_fs.c Is there anything suspicious in the kernel log w

Re: [REGRESSION] usb: gadget: f_fs: Allow scatter-gather buffers

2019-05-14 Thread Andrzej Pietrasiewicz
Hi, W dniu 13.05.2019 o 20:09, John Stultz pisze: On Mon, May 13, 2019 at 7:08 AM Andrzej Pietrasiewicz wrote: Do you get "functionfs read size 512 > requested size 24, splitting request into multiple reads" message when problems happen? Unfortunately no. Actually that's a fortunate o

Re: [REGRESSION] usb: gadget: f_fs: Allow scatter-gather buffers

2019-05-09 Thread John Stultz
On Thu, May 9, 2019 at 11:25 AM John Stultz wrote: > > On Thu, May 9, 2019 at 7:02 AM Andrzej Pietrasiewicz > wrote: > > > > Hi John, > > W dniu 08.05.2019 o 04:18, John Stultz pisze: > > > Since commit 772a7a724f69 ("usb: gadget: f_fs: Allow scatter-gather > > > buffers"), I've been seeing troub

Re: [REGRESSION] usb: gadget: f_fs: Allow scatter-gather buffers

2019-05-09 Thread Andrzej Pietrasiewicz
Hi John, W dniu 08.05.2019 o 04:18, John Stultz pisze: Since commit 772a7a724f69 ("usb: gadget: f_fs: Allow scatter-gather buffers"), I've been seeing trouble with adb transfers in Android on HiKey960, HiKey and now Dragonboard 845c. Sometimes things crash, but often the transfers just stop w/o

Re: [REGRESSION] usb: gadget: f_fs: Allow scatter-gather buffers

2019-05-08 Thread John Stultz
On Wed, May 8, 2019 at 12:01 AM Andrzej Pietrasiewicz wrote: > W dniu 08.05.2019 o 04:18, John Stultz pisze: > > Andrzej: Do you have any ideas or suggestions on this? I'm happy to > > test or run any debug patches, if it would help narrow the issue down. > > > > There is a patch: > > https://www.