Re: [RESEND][PATCH] ARM: PL011: add support for extended FIFO-size of PL011-r1p5

2013-04-22 Thread Russell King - ARM Linux
On Mon, Apr 22, 2013 at 11:24:18AM +0900, Jongsung Kim wrote: > Thank you for your comments, Russell. I'll happily apply your recommendation > just after it come up to the merge window. Or, do you want me to send it by > now? Sorry, don't understand what you're asking, could you rephrase please? -

RE: [RESEND][PATCH] ARM: PL011: add support for extended FIFO-size of PL011-r1p5

2013-04-21 Thread Jongsung Kim
PM To: Jongsung Kim Cc: gre...@linuxfoundation.org; jsl...@suse.cz; linux-ser...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [RESEND][PATCH] ARM: PL011: add support for extended FIFO-size of PL011-r1p5 On Mon, Apr 15, 2013 at 02:45:25PM +0900, Jongsung Kim wrote: > The latest r1p5-revisio

Re: [RESEND][PATCH] ARM: PL011: add support for extended FIFO-size of PL011-r1p5

2013-04-21 Thread Russell King - ARM Linux
On Sat, Apr 20, 2013 at 03:31:39PM +0200, Linus Walleij wrote: > static struct amba_id pl011_ids[] = { > { > .id = 0x00341011, > .mask = 0x00ff, > .data = &vendor_arm_deepfifo, > }, > (...) > }; > > As you can see in amba_

Re: [RESEND][PATCH] ARM: PL011: add support for extended FIFO-size of PL011-r1p5

2013-04-20 Thread Linus Walleij
On Mon, Apr 15, 2013 at 7:45 AM, Jongsung Kim wrote: At the risk to re-stating what Russell has already said... > + > + unsigned int (*get_fifosize)(unsigned int periphid); > }; > > +static unsigned int get_fifosize_arm(unsigned int periphid) > +{ > + unsigned int rev = (periphid >>

Re: [RESEND][PATCH] ARM: PL011: add support for extended FIFO-size of PL011-r1p5

2013-04-19 Thread Russell King - ARM Linux
On Mon, Apr 15, 2013 at 02:45:25PM +0900, Jongsung Kim wrote: > The latest r1p5-revision of the ARM PL011 UART has 32-byte FIFOs, > while all earlier ones have 16-byte FIFOs. This patch suggests > a way to set the FIFO-size correctly & flexibly by using a member > function named get_fifosize, rathe