Re: [RESEND RFC PATCH 2/3] ASoC: mediatek: Add AFE connection control

2015-04-21 Thread Mark Brown
On Tue, Apr 21, 2015 at 07:50:41AM +0200, Sascha Hauer wrote: > Oh, that's not magic at all, the crossbar switch has inputs and outputs > numbered from 0 to MTK_AFE_INTERCONN_NUM_INPUT / > MTK_AFE_INTERCONN_NUM_OUTPUT (they have the same numbers in the > datasheet. To connect input x with output y

Re: [RESEND RFC PATCH 2/3] ASoC: mediatek: Add AFE connection control

2015-04-20 Thread Sascha Hauer
On Mon, Apr 20, 2015 at 09:52:30PM +0100, Mark Brown wrote: > On Mon, Apr 20, 2015 at 06:50:17AM +0200, Sascha Hauer wrote: > > On Sat, Apr 18, 2015 at 06:37:40PM +0100, Mark Brown wrote: > > > On Fri, Apr 10, 2015 at 04:14:08PM +0800, Koro Chen wrote: > > > > > + [0][0] = { .creg = 0x020,

Re: [RESEND RFC PATCH 2/3] ASoC: mediatek: Add AFE connection control

2015-04-20 Thread Mark Brown
On Mon, Apr 20, 2015 at 06:50:17AM +0200, Sascha Hauer wrote: > On Sat, Apr 18, 2015 at 06:37:40PM +0100, Mark Brown wrote: > > On Fri, Apr 10, 2015 at 04:14:08PM +0800, Koro Chen wrote: > > > + [0][0] = { .creg = 0x020, .cshift = 0, .sreg = 0x020, .sshift = 10}, > > > + [0][1] = { .creg = 0x

Re: [RESEND RFC PATCH 2/3] ASoC: mediatek: Add AFE connection control

2015-04-19 Thread Sascha Hauer
On Sat, Apr 18, 2015 at 06:37:40PM +0100, Mark Brown wrote: > On Fri, Apr 10, 2015 at 04:14:08PM +0800, Koro Chen wrote: > > > +/* > > + * The MTK AFE unit has a audio interconnect with > > MTK_AFE_INTERCONN_NUM_INPUT > > + * inputs and MTK_AFE_INTERCONN_NUM_OUTPUT outputs. Below table holds the

Re: [RESEND RFC PATCH 2/3] ASoC: mediatek: Add AFE connection control

2015-04-18 Thread Mark Brown
On Fri, Apr 10, 2015 at 04:14:08PM +0800, Koro Chen wrote: > +/* > + * The MTK AFE unit has a audio interconnect with MTK_AFE_INTERCONN_NUM_INPUT > + * inputs and MTK_AFE_INTERCONN_NUM_OUTPUT outputs. Below table holds the > + * register/bits to set to connect an input with an output. > + */ > +st