Re: [RESENDx2][PATCH] sound: qcom: Kconfig: Tweak dependencies on SND_SOC_SDM845

2020-06-16 Thread Mark Brown
On Tue, Jun 16, 2020 at 11:01:02AM -0700, John Stultz wrote: > On Tue, Jun 16, 2020 at 1:25 AM Srinivas Kandagatla > > > + select SND_SOC_CROS_EC_CODEC if CROS_EC > > Isn't "imply SND_SOC_CROS_EC_CODEC" better option here? > I've honestly not gotten my head around "imply", so I'll have to ta

Re: [RESENDx2][PATCH] sound: qcom: Kconfig: Tweak dependencies on SND_SOC_SDM845

2020-06-16 Thread John Stultz
On Tue, Jun 16, 2020 at 1:25 AM Srinivas Kandagatla wrote: > On 16/06/2020 07:34, John Stultz wrote: > > CROS_EC isn't strictly required for audio to work > > on other SDM845 platforms (like the Dragonboard 845c). > > > > So lets remove the dependency and select the related > > CROS_EC options if

Re: [RESENDx2][PATCH] sound: qcom: Kconfig: Tweak dependencies on SND_SOC_SDM845

2020-06-16 Thread Mark Brown
On Tue, Jun 16, 2020 at 06:34:17AM +, John Stultz wrote: > CROS_EC isn't strictly required for audio to work > on other SDM845 platforms (like the Dragonboard 845c). Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify re

Re: [RESENDx2][PATCH] sound: qcom: Kconfig: Tweak dependencies on SND_SOC_SDM845

2020-06-16 Thread Srinivas Kandagatla
On 16/06/2020 07:34, John Stultz wrote: CROS_EC isn't strictly required for audio to work on other SDM845 platforms (like the Dragonboard 845c). So lets remove the dependency and select the related CROS_EC options if CROS_EC is already enabled. Sorry John, totally missed this one out! Cc