Re: [RFC, PATCH 1/3] gpiodev - API definitions

2007-04-12 Thread Paul Sokolovsky
Hello Juergen, Wednesday, April 11, 2007, 9:47:01 AM, you wrote: > Am Dienstag, 10. April 2007 23:30 schrieb Paul Sokolovsky: >> Hello linux-arm-kernel, >> >> GPIODEV API: Core API definitions. Provided are: >> 1. struct gpiodev_ops which must be included into platform_data structure >> of a devi

Re: [RFC, PATCH 1/3] gpiodev - API definitions

2007-04-11 Thread Russell King
On Wed, Apr 11, 2007 at 08:47:01AM +0200, Juergen Schindele wrote: > Am Dienstag, 10. April 2007 23:30 schrieb Paul Sokolovsky: > > +static inline int gpiodev_get_value(struct gpio *gpio) > > +{ > > + struct gpiodev_ops *ops = gpio->gpio_dev->dev.platform_data; > > wouldn't it be more sure t

Re: [RFC, PATCH 1/3] gpiodev - API definitions

2007-04-11 Thread Juergen Schindele
Am Dienstag, 10. April 2007 23:30 schrieb Paul Sokolovsky: > Hello linux-arm-kernel, > > GPIODEV API: Core API definitions. Provided are: > 1. struct gpiodev_ops which must be included into platform_data structure > of a device which will provide GPIODEV API; driver for a device must > initialize t

Re: [RFC, PATCH 1/3] gpiodev - API definitions

2007-04-10 Thread Paul Sokolovsky
Hello Eric, Wednesday, April 11, 2007, 3:30:45 AM, you wrote: > it looks ok, but I have several questions: > 1. why should we bind this to platform_device, what if the gpio device > is not actually a "platform_device", say, a I2C device, a SPI device or > even a USB device? Good point. That w

Re: [RFC, PATCH 1/3] gpiodev - API definitions

2007-04-10 Thread Eric Miao
it looks ok, but I have several questions: 1. why should we bind this to platform_device, what if the gpio device is not actually a "platform_device", say, a I2C device, a SPI device or even a USB device? 2. I still doubt the benefit of using of a structure for a gpio, isn't a gpio number not en