Re: [RFC][PATCH 00/14] VFS: Make all filesystems implement ->show_options()

2017-07-08 Thread Theodore Ts'o
On Fri, Jul 07, 2017 at 04:58:56PM +0100, David Howells wrote: > Yeah. We actually currently get this *wrong* in both ext4 and btrfs - and > probably other disk filesystems too. During ext4 remount and btrfs remount, > the options are parsed directly into the live xxx_fs_info struct, but if > the

Re: [RFC][PATCH 00/14] VFS: Make all filesystems implement ->show_options()

2017-07-07 Thread David Howells
Eric W. Biederman wrote: > > This makes it easier to implement a context-based mount where the options > > are passed individually over a file descriptor. It also allows duplicate > > options, options that override each other and ignored options to be > > resolved rather than storing irrelevant

Re: [RFC][PATCH 00/14] VFS: Make all filesystems implement ->show_options()

2017-07-05 Thread Eric W. Biederman
David Howells writes: > Here's a set of patches that: > > (1) Removes calls to save/replace_mount_options() where the filesystem > then implements ->show_options() anyway, ignoring ->s_options. > > (2) Makes all filesystems implement the ->show_options() superblock > operation rather