Re: [RFC][PATCH 1/1] support for user-space buffers in kfifo

2007-06-12 Thread Stelian Pop
Le mardi 12 juin 2007 à 21:21 -0500, Nelson Castillo a écrit : > On 6/12/07, Stelian Pop <[EMAIL PROTECTED]> wrote: > > Le mardi 12 juin 2007 à 11:24 -0500, Nelson Castillo a écrit : > > > On 6/12/07, Stelian Pop <[EMAIL PROTECTED]> wrote: > > > (cut) > > > > accessing userspace memory with a spinl

Re: [RFC][PATCH 1/1] support for user-space buffers in kfifo

2007-06-12 Thread Nelson Castillo
On 6/12/07, Stelian Pop <[EMAIL PROTECTED]> wrote: > Le mardi 12 juin 2007 à 11:24 -0500, Nelson Castillo a écrit : > > On 6/12/07, Stelian Pop <[EMAIL PROTECTED]> wrote: > > (cut) > > > accessing userspace memory with a spinlock taken (moreover an > > > irqsave() > > > one) is bad bad bad. > > > >

Re: [RFC][PATCH 1/1] support for user-space buffers in kfifo

2007-06-12 Thread Stelian Pop
Le mardi 12 juin 2007 à 11:24 -0500, Nelson Castillo a écrit : > On 6/12/07, Stelian Pop <[EMAIL PROTECTED]> wrote: > (cut) > > accessing userspace memory with a spinlock taken (moreover an > > irqsave() > > one) is bad bad bad. > > Hi Stelian. > > I'm sending the new patch without kfifo_put_user

Re: [RFC][PATCH 1/1] support for user-space buffers in kfifo

2007-06-12 Thread Nelson Castillo
On 6/12/07, Stelian Pop <[EMAIL PROTECTED]> wrote: (cut) > accessing userspace memory with a spinlock taken (moreover an > irqsave() > one) is bad bad bad. Hi Stelian. I'm sending the new patch without kfifo_put_user and kfifo_get_user. Regards, Nelson.- Signed-off-by: Nelson Castillo <[EMAIL P

Re: [RFC][PATCH 1/1] support for user-space buffers in kfifo

2007-06-12 Thread Nelson Castillo
On 6/12/07, Stelian Pop <[EMAIL PROTECTED]> wrote: Le lundi 11 juin 2007 à 16:26 -0500, Nelson Castillo a écrit : > Hi. > > I just added support for user space buffers in kfifo. I found useful > __kfifo_get_user to copy data to a user buffer in a read call. I didn't > like the idea of having an e

Re: [RFC][PATCH 1/1] support for user-space buffers in kfifo

2007-06-12 Thread Stelian Pop
Le lundi 11 juin 2007 à 16:26 -0500, Nelson Castillo a écrit : > Hi. > > I just added support for user space buffers in kfifo. I found useful > __kfifo_get_user to copy data to a user buffer in a read call. I didn't > like the idea of having an extra buffer. > > * Is it ok to add this support? I