Re: [RFC][PATCH 1/9] irq_work: Cleanup

2020-08-18 Thread peterz
On Mon, Aug 17, 2020 at 06:00:05AM -0700, Paul E. McKenney wrote: > On Mon, Aug 17, 2020 at 11:16:33AM +0200, pet...@infradead.org wrote: > > On Mon, Aug 17, 2020 at 11:03:25AM +0200, pet...@infradead.org wrote: > > > On Thu, Jul 23, 2020 at 09:14:11AM -0700, Paul E. McKenney wrote: > > > > > ---

Re: [RFC][PATCH 1/9] irq_work: Cleanup

2020-08-17 Thread Paul E. McKenney
On Mon, Aug 17, 2020 at 11:16:33AM +0200, pet...@infradead.org wrote: > On Mon, Aug 17, 2020 at 11:03:25AM +0200, pet...@infradead.org wrote: > > On Thu, Jul 23, 2020 at 09:14:11AM -0700, Paul E. McKenney wrote: > > > > --- a/kernel/rcu/tree.c > > > > +++ b/kernel/rcu/tree.c > > > > @@ -1287,8

Re: [RFC][PATCH 1/9] irq_work: Cleanup

2020-08-17 Thread peterz
On Mon, Aug 17, 2020 at 11:03:25AM +0200, pet...@infradead.org wrote: > On Thu, Jul 23, 2020 at 09:14:11AM -0700, Paul E. McKenney wrote: > > > --- a/kernel/rcu/tree.c > > > +++ b/kernel/rcu/tree.c > > > @@ -1287,8 +1287,6 @@ static int rcu_implicit_dynticks_qs(stru > > > if

Re: [RFC][PATCH 1/9] irq_work: Cleanup

2020-08-17 Thread peterz
On Thu, Jul 23, 2020 at 09:14:11AM -0700, Paul E. McKenney wrote: > > --- a/kernel/rcu/tree.c > > +++ b/kernel/rcu/tree.c > > @@ -1287,8 +1287,6 @@ static int rcu_implicit_dynticks_qs(stru > > if (IS_ENABLED(CONFIG_IRQ_WORK) && > > !rdp->rcu_iw_pending &&

Re: [RFC][PATCH 1/9] irq_work: Cleanup

2020-07-25 Thread Peter Zijlstra
On Sat, Jul 25, 2020 at 01:58:28PM +0200, Ingo Molnar wrote: > > * Peter Zijlstra wrote: > > > Get rid of the __call_single_node union and clean up the API a little > > to avoid external code relying on the structure layout as much. > > > > Signed-off-by: Peter Zijlstra (Intel) > > --- > >

Re: [RFC][PATCH 1/9] irq_work: Cleanup

2020-07-25 Thread Ingo Molnar
* Peter Zijlstra wrote: > Get rid of the __call_single_node union and clean up the API a little > to avoid external code relying on the structure layout as much. > > Signed-off-by: Peter Zijlstra (Intel) > --- > drivers/gpu/drm/i915/i915_request.c |4 ++-- > include/linux/irq_work.h

Re: [RFC][PATCH 1/9] irq_work: Cleanup

2020-07-23 Thread Paul E. McKenney
On Wed, Jul 22, 2020 at 05:01:50PM +0200, Peter Zijlstra wrote: > Get rid of the __call_single_node union and clean up the API a little > to avoid external code relying on the structure layout as much. > > Signed-off-by: Peter Zijlstra (Intel) As noted earlier, cleaning up that union is most