Re: [RFC][PATCH 2/8] x86/mm: break out kernel address space handling

2018-09-07 Thread Dave Hansen
On 09/07/2018 03:21 PM, Andy Lutomirski wrote: >> +static void >> +do_kern_addr_space_fault(struct pt_regs *regs, unsigned long hw_error_code, >> + unsigned long address) >> +{ > > Can you add a comment above this documenting *when* it’s called? Is > it all faults, !user_mode faults, or

Re: [RFC][PATCH 2/8] x86/mm: break out kernel address space handling

2018-09-07 Thread Andy Lutomirski
> On Sep 7, 2018, at 12:48 PM, Dave Hansen wrote: > > > From: Dave Hansen > > The page fault handler (__do_page_fault()) basically has two sections: > one for handling faults in the kernel porttion of the address space > and another for faults in the user porttion of the address space. >

Re: [RFC][PATCH 2/8] x86/mm: break out kernel address space handling

2018-09-07 Thread Dave Hansen
On 09/07/2018 02:06 PM, Sean Christopherson wrote: >> The page fault handler (__do_page_fault())  basically has two sections: >> one for handling faults in the kernel porttion of the address space >> and another for faults in the user porttion of the address space. > %s/porttion/portion Fixed, tha

Re: [RFC][PATCH 2/8] x86/mm: break out kernel address space handling

2018-09-07 Thread Sean Christopherson
On Fri, 2018-09-07 at 12:48 -0700, Dave Hansen wrote: > From: Dave Hansen > > The page fault handler (__do_page_fault())  basically has two sections: > one for handling faults in the kernel porttion of the address space > and another for faults in the user porttion of the address space. %s/portt