Re: [RFC][PATCH 6/6] x86/entry: Remove DBn stacks

2020-05-28 Thread Peter Zijlstra
On Fri, May 29, 2020 at 06:35:07AM +0800, Lai Jiangshan wrote: > There will be a compile error about N_EXCEPTION_STACKS > in arch/x86/kernel/dumpstack_64.c. It should have > > - BUILD_BUG_ON(N_EXCEPTION_STACKS != 6); > + BUILD_BUG_ON(N_EXCEPTION_STACKS != 4); Yeah, I actually have that, but forgo

Re: [RFC][PATCH 6/6] x86/entry: Remove DBn stacks

2020-05-28 Thread Lai Jiangshan
On Fri, May 29, 2020 at 4:26 AM Peter Zijlstra wrote: > > Both #DB itself, as all other IST users (NMI, #MC) now clear DR7 on > entry. Combined with not allowing breakpoints on entry/noinstr/NOKPROBE > text and no single step (EFLAGS.TF) inside the #DB handler should > guarantee us no nested #DB.