Re: [RFC][PATCH v3] slub: Keep page and object in sync in slab_alloc_node()

2013-01-20 Thread Christoph Lameter
On Fri, 18 Jan 2013, Eric Dumazet wrote: > On Fri, 2013-01-18 at 18:40 +, Christoph Lameter wrote: > > > The fetching of the tid is the only critical thing here. If the tid is > > retrieved from the right cpu then the cmpxchg will fail if any changes > > occured to freelist or the page variabl

Re: [RFC][PATCH v3] slub: Keep page and object in sync in slab_alloc_node()

2013-01-18 Thread Steven Rostedt
On Fri, 2013-01-18 at 11:09 -0800, Eric Dumazet wrote: > On Fri, 2013-01-18 at 18:40 +, Christoph Lameter wrote: > > > The fetching of the tid is the only critical thing here. If the tid is > > retrieved from the right cpu then the cmpxchg will fail if any changes > > occured to freelist or th

Re: [RFC][PATCH v3] slub: Keep page and object in sync in slab_alloc_node()

2013-01-18 Thread Eric Dumazet
On Fri, 2013-01-18 at 18:40 +, Christoph Lameter wrote: > The fetching of the tid is the only critical thing here. If the tid is > retrieved from the right cpu then the cmpxchg will fail if any changes > occured to freelist or the page variable. > > The tid can be retrieved without disabling

Re: [RFC][PATCH v3] slub: Keep page and object in sync in slab_alloc_node()

2013-01-18 Thread Christoph Lameter
On Fri, 18 Jan 2013, Steven Rostedt wrote: > @@ -2337,7 +2337,10 @@ redo: >* enabled. We may switch back and forth between cpus while >* reading from one cpu area. That does not matter as long >* as we end up on the original cpu again when doing the cmpxchg. > + * > +