Re: [RFC] IB/srp: Remove create_workqueue

2016-06-21 Thread Bart Van Assche
On 06/20/2016 08:59 PM, Tejun Heo wrote: On Tue, Jun 07, 2016 at 01:00:13PM -0700, Bart Van Assche wrote: srp_remove_wq is used for SRP target port removal work only. This work is neither queued from inside a shrinker nor by the page writeback code so I think it is safe to drop WQ_MEM_RECLAIM.

Re: [RFC] IB/srp: Remove create_workqueue

2016-06-20 Thread Tejun Heo
Hello, Bart. On Tue, Jun 07, 2016 at 01:00:13PM -0700, Bart Van Assche wrote: > > > > srp_remove_wq is used for SRP target port removal work only. This work > > > > is > > > > neither queued from inside a shrinker nor by the page writeback code so > > > > I > > > > think it is safe to drop WQ_ME

Re: [RFC] IB/srp: Remove create_workqueue

2016-06-07 Thread Bart Van Assche
On 06/07/2016 12:56 PM, Bart Van Assche wrote: On 06/07/2016 12:21 PM, Tejun Heo wrote: On Tue, Jun 07, 2016 at 11:32:42AM -0700, Bart Van Assche wrote: On 06/07/2016 11:16 AM, Bhaktipriya Shridhar wrote: alloc_workqueue replaces deprecated create_workqueue(). A dedicated workqueue has been u

Re: [RFC] IB/srp: Remove create_workqueue

2016-06-07 Thread Bart Van Assche
On 06/07/2016 12:21 PM, Tejun Heo wrote: On Tue, Jun 07, 2016 at 11:32:42AM -0700, Bart Van Assche wrote: On 06/07/2016 11:16 AM, Bhaktipriya Shridhar wrote: alloc_workqueue replaces deprecated create_workqueue(). A dedicated workqueue has been used since the workqueue srp_remove_wq with worki

Re: [RFC] IB/srp: Remove create_workqueue

2016-06-07 Thread Tejun Heo
On Tue, Jun 07, 2016 at 11:32:42AM -0700, Bart Van Assche wrote: > On 06/07/2016 11:16 AM, Bhaktipriya Shridhar wrote: > > alloc_workqueue replaces deprecated create_workqueue(). > > > > A dedicated workqueue has been used since the workqueue srp_remove_wq with > > workitem &target->remove_work, i

Re: [RFC] IB/srp: Remove create_workqueue

2016-06-07 Thread Bart Van Assche
On 06/07/2016 11:16 AM, Bhaktipriya Shridhar wrote: alloc_workqueue replaces deprecated create_workqueue(). A dedicated workqueue has been used since the workqueue srp_remove_wq with workitem &target->remove_work, is a work queue for the SRP target removal. WQ_MEM_RECLAIM has been set to ensure