Re: [RFC] cpuidle - remove the power_specified field in the driver

On 12/10/2012 08:09 PM, Julius Werner wrote: > Hi, > > What is the current status of this? Daniel, do you think you have got > enough feedback to submit a definitive patch for this? Yes, I have a definitive patch. I will resend it tomorrow. Thanks -- Daniel -- To unsubscribe from this list: s

Re: [RFC] cpuidle - remove the power_specified field in the driver

On Monday, December 10, 2012 11:09:58 AM Julius Werner wrote: > Hi, > > What is the current status of this? Daniel, do you think you have got > enough feedback to submit a definitive patch for this? Rafael, would > you approve of such a change? I need to talk to Len about that before I give you a

Re: [RFC] cpuidle - remove the power_specified field in the driver

Hi, What is the current status of this? Daniel, do you think you have got enough feedback to submit a definitive patch for this? Rafael, would you approve of such a change? The bug with dynamically added C-states that is tied to this still hurts the battery life for some users across all distros

Re: [RFC] cpuidle - remove the power_specified field in the driver

On 11/18/2012 09:40 AM, Francesco Lavra wrote: > Hi, > > On 11/12/2012 09:26 PM, Daniel Lezcano wrote: >> This patch follows the discussion about reinitializing the power usage >> when a C-state is added/removed. >> >> https://lkml.org/lkml/2012/10/16/518 >> >> We realized the power usage field i

Re: [RFC] cpuidle - remove the power_specified field in the driver

Hi, On 11/12/2012 09:26 PM, Daniel Lezcano wrote: > This patch follows the discussion about reinitializing the power usage > when a C-state is added/removed. > > https://lkml.org/lkml/2012/10/16/518 > > We realized the power usage field is never filled and when it is > filled for tegra, the pow

Re: [RFC] cpuidle - remove the power_specified field in the driver

On 11/12/2012 10:09 PM, Julius Werner wrote: > Thanks for moving this along, Daniel. I think this is the right > approach... the cpuidle driver shouldn't be more complex than > necessary. > > Note that you are starting your loop too high in cpuidle_play_dead... > states[state_count] is not an actu

Re: [RFC] cpuidle - remove the power_specified field in the driver

Thanks for moving this along, Daniel. I think this is the right approach... the cpuidle driver shouldn't be more complex than necessary. Note that you are starting your loop too high in cpuidle_play_dead... states[state_count] is not an actual state anymore, it should start at state_count - 1. Als