Re: [RFC] pinctrl driver for Zynq

2014-10-08 Thread Sören Brinkmann
On Tue, 2014-10-07 at 01:05PM +0200, Linus Walleij wrote: > On Wed, Sep 24, 2014 at 11:09 PM, Sören Brinkmann [...] > > +++ b/drivers/pinctrl/Kconfig > > @@ -305,6 +305,14 @@ config PINCTRL_PALMAS > > open drain configuration for the Palmas series devices like > > TPS65913, TPS8

Re: [RFC] pinctrl driver for Zynq

2014-10-07 Thread Sören Brinkmann
Hi Linus, thanks for the review. On Tue, 2014-10-07 at 01:05PM +0200, Linus Walleij wrote: > On Wed, Sep 24, 2014 at 11:09 PM, Sören Brinkmann > wrote: > > > I think I have pinctrl driver that is covering the pinmux options of > > Zynq and I also figured out how the DT bindings work. > > OK le

Re: [RFC] pinctrl driver for Zynq

2014-10-07 Thread Michal Simek
Hi Linus, Soren will reply it I believe just some explanation from me. >> diff --git a/arch/arm/boot/dts/zynq-zc706.dts >> b/arch/arm/boot/dts/zynq-zc706.dts >> index 4cc9913078cd..1ae9bcaee252 100644 >> --- a/arch/arm/boot/dts/zynq-zc706.dts >> +++ b/arch/arm/boot/dts/zynq-zc706.dts >> @@ -33,1

Re: [RFC] pinctrl driver for Zynq

2014-10-07 Thread Linus Walleij
On Thu, Sep 25, 2014 at 6:02 PM, Sören Brinkmann wrote: > On Thu, 2014-09-25 at 10:17AM +0200, Steffen Trumtrar wrote: >> On Wed, Sep 24, 2014 at 02:09:14PM -0700, Sören Brinkmann wrote: >> (...) >> >> > + pinctrl_sdio1_cd_54: pinctrl-sdio1_cd@54 { >> > +

Re: [RFC] pinctrl driver for Zynq

2014-10-07 Thread Linus Walleij
On Wed, Sep 24, 2014 at 11:09 PM, Sören Brinkmann wrote: > I think I have pinctrl driver that is covering the pinmux options of > Zynq and I also figured out how the DT bindings work. OK let's look > One thing making the DT bindings explode, seems to be all those single > pin functions that

Re: [RFC] pinctrl driver for Zynq

2014-09-25 Thread Sören Brinkmann
On Thu, 2014-09-25 at 10:17AM +0200, Steffen Trumtrar wrote: > Hi! > > On Wed, Sep 24, 2014 at 02:09:14PM -0700, Sören Brinkmann wrote: > > Hi, > > > > I think I have pinctrl driver that is covering the pinmux options of > > Zynq and I also figured out how the DT bindings work. > > > > But there

Re: [RFC] pinctrl driver for Zynq

2014-09-25 Thread Steffen Trumtrar
Hi! On Wed, Sep 24, 2014 at 02:09:14PM -0700, Sören Brinkmann wrote: > Hi, > > I think I have pinctrl driver that is covering the pinmux options of > Zynq and I also figured out how the DT bindings work. > > But there are a couple of things that probably could be done better. > > One thing maki