Re: [RFC] regmap: Add regmap_pipe_read API

2016-06-22 Thread Mark Brown
On Wed, Jun 22, 2016 at 11:32:20AM +0300, Crestez Dan Leonard wrote: > On 06/21/2016 09:42 PM, Mark Brown wrote: > > On Thu, Jun 16, 2016 at 06:24:36PM +0300, Crestez Dan Leonard wrote: > >> + val = ((u8*)val) + read_len; > > This cast looks broken, you should be able to do pointer arith

Re: [RFC] regmap: Add regmap_pipe_read API

2016-06-22 Thread Crestez Dan Leonard
On 06/21/2016 09:42 PM, Mark Brown wrote: > On Thu, Jun 16, 2016 at 06:24:36PM +0300, Crestez Dan Leonard wrote: > >> +val = ((u8*)val) + read_len; > > This cast looks broken, you should be able to do pointer arithmetic on > void pointers as though they were char *. > Pointer arithme

Re: [RFC] regmap: Add regmap_pipe_read API

2016-06-21 Thread Mark Brown
On Thu, Jun 16, 2016 at 06:24:36PM +0300, Crestez Dan Leonard wrote: > + val = ((u8*)val) + read_len; This cast looks broken, you should be able to do pointer arithmetic on void pointers as though they were char *. signature.asc Description: PGP signature

Re: [RFC] regmap: Add regmap_pipe_read API

2016-06-19 Thread Jonathan Cameron
On 17/06/16 09:05, Lars-Peter Clausen wrote: > On 06/17/2016 09:04 AM, Crestez Dan Leonard wrote: >> On 06/16/2016 06:43 PM, Geert Uytterhoeven wrote: >>> Hi Leonard, >>> >>> On Thu, Jun 16, 2016 at 5:24 PM, Crestez Dan Leonard >>> wrote: The regmap API usually assumes that bulk read operatio

Re: [RFC] regmap: Add regmap_pipe_read API

2016-06-17 Thread Lars-Peter Clausen
On 06/17/2016 09:04 AM, Crestez Dan Leonard wrote: > On 06/16/2016 06:43 PM, Geert Uytterhoeven wrote: >> Hi Leonard, >> >> On Thu, Jun 16, 2016 at 5:24 PM, Crestez Dan Leonard >> wrote: >>> The regmap API usually assumes that bulk read operations will read a >>> range of registers but some I2C/SP

Re: [RFC] regmap: Add regmap_pipe_read API

2016-06-17 Thread Crestez Dan Leonard
On 06/16/2016 06:43 PM, Geert Uytterhoeven wrote: > Hi Leonard, > > On Thu, Jun 16, 2016 at 5:24 PM, Crestez Dan Leonard > wrote: >> The regmap API usually assumes that bulk read operations will read a >> range of registers but some I2C/SPI devices have certain registers for >> which a such a rea

Re: [RFC] regmap: Add regmap_pipe_read API

2016-06-16 Thread Geert Uytterhoeven
Hi Leonard, On Thu, Jun 16, 2016 at 5:24 PM, Crestez Dan Leonard wrote: > The regmap API usually assumes that bulk read operations will read a > range of registers but some I2C/SPI devices have certain registers for > which a such a read operation will return data from an internal FIFO > instead.