Re: Re: [RFC PATCH] suspend/resume performance improvement

2015-05-27 Thread EunTaik Lee
On Tue 2015-05-27 16:50 (GMT+09:00), Pavel Machek wrote: >> So, instead of depending on a userspace task's time >> slice, let kworker do the work to avoid a long wait >> on the runqueue. > >...so if you really want high priority for that operation, just renice >yourself to higher priority or some

Re: [RFC PATCH] suspend/resume performance improvement

2015-05-27 Thread Pavel Machek
On Tue 2015-05-26 14:05:47, 이은택 wrote: > When a task that calls state_store() to suspend > the device has used up most of its time slice, > suspend sometimes take too long. (User noticeable) > > Suspend/resume is a system wide operation. It is also root-only. > So, instead of depending on a user

Re: Re: [RFC PATCH] suspend/resume performance improvement

2015-05-26 Thread EunTaik Lee
> Instead of replicating code in state_store here, does it make sense to > move into a common part, so that fixes/optimization can be done in one > place? > Also why another config? If this has proven benefit then it can be > default path. I agree. I will resend the patch if this patch is agreed t

Re: Re: [RFC PATCH] suspend/resume performance improvement

2015-05-26 Thread EunTaik Lee
>> When a task that calls state_store() to suspend >> the device has used up most of its time slice, >> suspend sometimes take too long. (User noticeable) >> >> Suspend/resume is a system wide operation. >> So, instead of depending on a userspace task's time >> slice, let kworker do the work to a

Re: [RFC PATCH] suspend/resume performance improvement

2015-05-26 Thread Rafael J. Wysocki
On Tuesday, May 26, 2015 02:05:48 PM 이은택 wrote: > When a task that calls state_store() to suspend > the device has used up most of its time slice, > suspend sometimes take too long. (User noticeable) > > Suspend/resume is a system wide operation. > So, instead of depending on a userspace task's ti

Re: [RFC PATCH] suspend/resume performance improvement

2015-05-26 Thread Pandruvada, Srinivas
On Tue, 2015-05-26 at 14:05 +, 이은택 wrote: > When a task that calls state_store() to suspend > the device has used up most of its time slice, > suspend sometimes take too long. (User noticeable) > > Suspend/resume is a system wide operation. > So, instead of depending on a userspace task's time