Re: [RFC PATCH 06/12] PAT 64b: Add ioremap_wc support

2007-12-18 Thread Eric W. Biederman
"Siddha, Suresh B" <[EMAIL PROTECTED]> writes: > Yes. We are looking for comments for our proposal to track the > reserved/non-reserved regions some what different. > This is the critical issue which had been holding off PAT for years now... The mattr infrastructure appears to do a decent job of

Re: [RFC PATCH 06/12] PAT 64b: Add ioremap_wc support

2007-12-14 Thread Andi Kleen
> For now, we don't track RAM pages using memattr infrastructure. This is > because, > memattr infrastructure is not enough. i.e., while the page is getting > tracked using memattr infrastructure, > potentially the page can get > freed(a bug that we need to catch, to avoid attribute aliasing). T

Re: [RFC PATCH 06/12] PAT 64b: Add ioremap_wc support

2007-12-14 Thread Siddha, Suresh B
On Thu, Dec 13, 2007 at 09:48:36PM -0700, Eric W. Biederman wrote: > Roland Dreier <[EMAIL PROTECTED]> writes: > > > > > Also I didn't see anything like pgprot_wc() in the patchset (although > > > > > pgprot_writcombined. > > > > Oh I see it now (pgprot_writecombine() actually). > > > > However

Re: [RFC PATCH 06/12] PAT 64b: Add ioremap_wc support

2007-12-13 Thread Eric W. Biederman
Roland Dreier <[EMAIL PROTECTED]> writes: > > > Also I didn't see anything like pgprot_wc() in the patchset (although > > > pgprot_writcombined. > > Oh I see it now (pgprot_writecombine() actually). > > However the same comment as before applies: there needs to be a > fallback to pgprot_noncache

Re: [RFC PATCH 06/12] PAT 64b: Add ioremap_wc support

2007-12-13 Thread Roland Dreier
> > Also I didn't see anything like pgprot_wc() in the patchset (although > pgprot_writcombined. Oh I see it now (pgprot_writecombine() actually). However the same comment as before applies: there needs to be a fallback to pgprot_noncached() for all other architectures so that drivers can actu

Re: [RFC PATCH 06/12] PAT 64b: Add ioremap_wc support

2007-12-13 Thread Eric W. Biederman
Roland Dreier <[EMAIL PROTECTED]> writes: > > --- linux-2.6.24-rc4.orig/include/asm-x86/io_64.h 2007-12-11 > 14:24:56.0 -0800 > > +++ linux-2.6.24-rc4/include/asm-x86/io_64.h 2007-12-11 15:49:52.0 > -0800 > > @@ -142,7 +142,8 @@ > > * it's useful if some control registers are i

Re: [RFC PATCH 06/12] PAT 64b: Add ioremap_wc support

2007-12-13 Thread Roland Dreier
> --- linux-2.6.24-rc4.orig/include/asm-x86/io_64.h2007-12-11 > 14:24:56.0 -0800 > +++ linux-2.6.24-rc4/include/asm-x86/io_64.h 2007-12-11 15:49:52.0 > -0800 > @@ -142,7 +142,8 @@ > * it's useful if some control registers are in such an area and write > combining >