Re: [RFC PATCH 08/17] block: refactor __bio_copy_iov()

2014-12-23 Thread Dongsu Park
On 23.12.2014 02:45, Christoph Hellwig wrote: > > static int __bio_copy_iov(struct bio *bio, const struct iov_iter *iter, > > + int to_iov) > > { > > + int i; > > struct bio_vec *bvec; > > struct iov_iter iov_iter = *iter; > > Why not pass the iov_iter by value? Ag

Re: [RFC PATCH 08/17] block: refactor __bio_copy_iov()

2014-12-23 Thread Christoph Hellwig
> static int __bio_copy_iov(struct bio *bio, const struct iov_iter *iter, > + int to_iov) > { > + int i; > struct bio_vec *bvec; > struct iov_iter iov_iter = *iter; Why not pass the iov_iter by value? > bio_for_each_segment_all(bvec, bio, i) { > +