Re: [RFC PATCH 1/2] RISC-V: Mark existing SBI as legacy SBI.

2019-08-29 Thread h...@infradead.org
On Tue, Aug 27, 2019 at 08:37:27PM +, Atish Patra wrote: > That would split the implementation between C file & assembly file for > no good reason. > > How about moving everything in sbi.c and just write everything inline > assembly there. Well, if we implement it in pure assembly that would

Re: [RFC PATCH 1/2] RISC-V: Mark existing SBI as legacy SBI.

2019-08-28 Thread Palmer Dabbelt
On Tue, 27 Aug 2019 01:37:00 PDT (-0700), r...@linux.ibm.com wrote: On Tue, Aug 27, 2019 at 01:58:03PM +0530, Anup Patel wrote: On Tue, Aug 27, 2019 at 1:21 PM Mike Rapoport wrote: > > On Mon, Aug 26, 2019 at 04:32:55PM -0700, Atish Patra wrote: > > As per the new SBI specification, current SBI

Re: [RFC PATCH 1/2] RISC-V: Mark existing SBI as legacy SBI.

2019-08-27 Thread Atish Patra
On Tue, 2019-08-27 at 07:03 -0700, Christoph Hellwig wrote: > > +#define SBI_EXT_LEGACY_SET_TIMER 0x0 > > +#define SBI_EXT_LEGACY_CONSOLE_PUTCHAR 0x1 > > +#define SBI_EXT_LEGACY_CONSOLE_GETCHAR 0x2 > > +#define SBI_EXT_LEGACY_CLEAR_IPI 0x3 > > +#define SBI_EXT_LEGACY_SEND_IPI 0x4 > > +#define SBI_E

Re: [RFC PATCH 1/2] RISC-V: Mark existing SBI as legacy SBI.

2019-08-27 Thread Atish Patra
On Tue, 2019-08-27 at 10:51 +0300, Mike Rapoport wrote: > On Mon, Aug 26, 2019 at 04:32:55PM -0700, Atish Patra wrote: > > As per the new SBI specification, current SBI implementation is > > defined as legacy and will be removed/replaced in future. > > > > Rename existing implementation to reflect

Re: [RFC PATCH 1/2] RISC-V: Mark existing SBI as legacy SBI.

2019-08-27 Thread Christoph Hellwig
On Tue, Aug 27, 2019 at 07:03:04AM -0700, Christoph Hellwig wrote: > > +#define SBI_EXT_LEGACY_SET_TIMER 0x0 > > +#define SBI_EXT_LEGACY_CONSOLE_PUTCHAR 0x1 > > +#define SBI_EXT_LEGACY_CONSOLE_GETCHAR 0x2 > > +#define SBI_EXT_LEGACY_CLEAR_IPI 0x3 > > +#define SBI_EXT_LEGACY_SEND_IPI 0x4 > > +#defin

Re: [RFC PATCH 1/2] RISC-V: Mark existing SBI as legacy SBI.

2019-08-27 Thread Christoph Hellwig
> +#define SBI_EXT_LEGACY_SET_TIMER 0x0 > +#define SBI_EXT_LEGACY_CONSOLE_PUTCHAR 0x1 > +#define SBI_EXT_LEGACY_CONSOLE_GETCHAR 0x2 > +#define SBI_EXT_LEGACY_CLEAR_IPI 0x3 > +#define SBI_EXT_LEGACY_SEND_IPI 0x4 > +#define SBI_EXT_LEGACY_REMOTE_FENCE_I 0x5 > +#define SBI_EXT_LEGACY_REMOTE_SFENCE_VMA

Re: [RFC PATCH 1/2] RISC-V: Mark existing SBI as legacy SBI.

2019-08-27 Thread Mike Rapoport
On Tue, Aug 27, 2019 at 01:58:03PM +0530, Anup Patel wrote: > On Tue, Aug 27, 2019 at 1:21 PM Mike Rapoport wrote: > > > > On Mon, Aug 26, 2019 at 04:32:55PM -0700, Atish Patra wrote: > > > As per the new SBI specification, current SBI implementation is > > > defined as legacy and will be removed/

Re: [RFC PATCH 1/2] RISC-V: Mark existing SBI as legacy SBI.

2019-08-27 Thread Anup Patel
On Tue, Aug 27, 2019 at 1:21 PM Mike Rapoport wrote: > > On Mon, Aug 26, 2019 at 04:32:55PM -0700, Atish Patra wrote: > > As per the new SBI specification, current SBI implementation is > > defined as legacy and will be removed/replaced in future. > > > > Rename existing implementation to reflect

Re: [RFC PATCH 1/2] RISC-V: Mark existing SBI as legacy SBI.

2019-08-27 Thread Mike Rapoport
On Mon, Aug 26, 2019 at 04:32:55PM -0700, Atish Patra wrote: > As per the new SBI specification, current SBI implementation is > defined as legacy and will be removed/replaced in future. > > Rename existing implementation to reflect that. This patch is just > a preparatory patch for SBI v0.2 and d