Re: [RFC PATCH 1/3] mm, numa: rework do_pages_move

2018-01-03 Thread Michal Hocko
On Wed 03-01-18 15:06:49, Anshuman Khandual wrote: > On 01/03/2018 02:28 PM, Michal Hocko wrote: > > On Wed 03-01-18 14:12:17, Anshuman Khandual wrote: > >> On 12/08/2017 09:45 PM, Michal Hocko wrote: [...] > >>> @@ -1593,79 +1556,80 @@ static int do_pages_move(struct mm_struct *mm, > >>> nodemask

Re: [RFC PATCH 1/3] mm, numa: rework do_pages_move

2018-01-03 Thread Anshuman Khandual
On 01/03/2018 02:28 PM, Michal Hocko wrote: > On Wed 03-01-18 14:12:17, Anshuman Khandual wrote: >> On 12/08/2017 09:45 PM, Michal Hocko wrote: > [...] [...] >> >> This reuses the existing page allocation helper from migrate_pages() system >> call. But all these allocator helper names for migrate

Re: [RFC PATCH 1/3] mm, numa: rework do_pages_move

2018-01-03 Thread Michal Hocko
On Wed 03-01-18 14:12:17, Anshuman Khandual wrote: > On 12/08/2017 09:45 PM, Michal Hocko wrote: [...] > > @@ -986,7 +987,7 @@ static int migrate_to_node(struct mm_struct *mm, int > > source, int dest, > > flags | MPOL_MF_DISCONTIG_OK, &pagelist); > > > > if (!list_empty(

Re: [RFC PATCH 1/3] mm, numa: rework do_pages_move

2018-01-03 Thread Anshuman Khandual
On 12/08/2017 09:45 PM, Michal Hocko wrote: > From: Michal Hocko > > do_pages_move is supposed to move user defined memory (an array of > addresses) to the user defined numa nodes (an array of nodes one for > each address). The user provided status array then contains resulting > numa node for ea

Re: [RFC PATCH 1/3] mm, numa: rework do_pages_move

2018-01-02 Thread Anshuman Khandual
On 01/02/2018 05:42 PM, Michal Hocko wrote: > On Tue 02-01-18 16:55:46, Anshuman Khandual wrote: >> On 12/08/2017 09:45 PM, Michal Hocko wrote: >>> From: Michal Hocko >>> >>> do_pages_move is supposed to move user defined memory (an array of >>> addresses) to the user defined numa nodes (an array

Re: [RFC PATCH 1/3] mm, numa: rework do_pages_move

2018-01-02 Thread Michal Hocko
On Tue 02-01-18 16:55:46, Anshuman Khandual wrote: > On 12/08/2017 09:45 PM, Michal Hocko wrote: > > From: Michal Hocko > > > > do_pages_move is supposed to move user defined memory (an array of > > addresses) to the user defined numa nodes (an array of nodes one for > > each address). The user p

Re: [RFC PATCH 1/3] mm, numa: rework do_pages_move

2018-01-02 Thread Anshuman Khandual
On 12/08/2017 09:45 PM, Michal Hocko wrote: > From: Michal Hocko > > do_pages_move is supposed to move user defined memory (an array of > addresses) to the user defined numa nodes (an array of nodes one for > each address). The user provided status array then contains resulting > numa node for ea

Re: [RFC PATCH 1/3] mm, numa: rework do_pages_move

2017-12-15 Thread Michal Hocko
On Fri 15-12-17 12:51:25, Kirill A. Shutemov wrote: > On Fri, Dec 15, 2017 at 10:28:59AM +0100, Michal Hocko wrote: > > On Thu 14-12-17 18:35:58, Kirill A. Shutemov wrote: > > > On Wed, Dec 13, 2017 at 03:39:48PM +0100, Michal Hocko wrote: > > [...] > > > > + err = 0; > > > > + if (page

Re: [RFC PATCH 1/3] mm, numa: rework do_pages_move

2017-12-15 Thread Kirill A. Shutemov
On Fri, Dec 15, 2017 at 10:28:59AM +0100, Michal Hocko wrote: > On Thu 14-12-17 18:35:58, Kirill A. Shutemov wrote: > > On Wed, Dec 13, 2017 at 03:39:48PM +0100, Michal Hocko wrote: > [...] > > > + err = 0; > > > + if (page_to_nid(page) == node) > > > + goto out_putpage; > > > + > > > + err

Re: [RFC PATCH 1/3] mm, numa: rework do_pages_move

2017-12-15 Thread Michal Hocko
On Thu 14-12-17 18:35:58, Kirill A. Shutemov wrote: > On Wed, Dec 13, 2017 at 03:39:48PM +0100, Michal Hocko wrote: [...] > > + err = 0; > > + if (page_to_nid(page) == node) > > + goto out_putpage; > > + > > + err = -EACCES; > > + if (page_mapcount(page) > 1 && > > +

Re: [RFC PATCH 1/3] mm, numa: rework do_pages_move

2017-12-14 Thread Kirill A. Shutemov
On Wed, Dec 13, 2017 at 03:39:48PM +0100, Michal Hocko wrote: > This patch has been generated with --patience parameter as suggested by > Kirill and it realy seems to provide a more compact diff. > --- > From 1f529769d099ca605888b29059014e7c8f0bfd50 Mon Sep 17 00:00:00 2001 > From: Michal Hocko >

Re: [RFC PATCH 1/3] mm, numa: rework do_pages_move

2017-12-13 Thread Michal Hocko
This patch has been generated with --patience parameter as suggested by Kirill and it realy seems to provide a more compact diff. --- >From 1f529769d099ca605888b29059014e7c8f0bfd50 Mon Sep 17 00:00:00 2001 From: Michal Hocko Date: Fri, 8 Dec 2017 12:28:34 +0100 Subject: [PATCH] mm, numa: rework do

Re: [RFC PATCH 1/3] mm, numa: rework do_pages_move

2017-12-13 Thread Kirill A. Shutemov
On Wed, Dec 13, 2017 at 03:10:39PM +0100, Michal Hocko wrote: > On Wed 13-12-17 15:47:31, Kirill A. Shutemov wrote: > > On Wed, Dec 13, 2017 at 01:17:03PM +0100, Michal Hocko wrote: > > > On Wed 13-12-17 15:07:33, Kirill A. Shutemov wrote: > > > [...] > > > > The approach looks fine to me. > > > >

Re: [RFC PATCH 1/3] mm, numa: rework do_pages_move

2017-12-13 Thread Michal Hocko
On Wed 13-12-17 15:47:31, Kirill A. Shutemov wrote: > On Wed, Dec 13, 2017 at 01:17:03PM +0100, Michal Hocko wrote: > > On Wed 13-12-17 15:07:33, Kirill A. Shutemov wrote: > > [...] > > > The approach looks fine to me. > > > > > > But patch is rather large and hard to review. And how git mixed add

Re: [RFC PATCH 1/3] mm, numa: rework do_pages_move

2017-12-13 Thread Kirill A. Shutemov
On Wed, Dec 13, 2017 at 01:17:03PM +0100, Michal Hocko wrote: > On Wed 13-12-17 15:07:33, Kirill A. Shutemov wrote: > [...] > > The approach looks fine to me. > > > > But patch is rather large and hard to review. And how git mixed add/remove > > lines doesn't help too. Any chance to split it up fu

Re: [RFC PATCH 1/3] mm, numa: rework do_pages_move

2017-12-13 Thread Michal Hocko
On Wed 13-12-17 15:07:33, Kirill A. Shutemov wrote: [...] > The approach looks fine to me. > > But patch is rather large and hard to review. And how git mixed add/remove > lines doesn't help too. Any chance to split it up further? I was trying to do that but this is a drop in replacement so it is

Re: [RFC PATCH 1/3] mm, numa: rework do_pages_move

2017-12-13 Thread Kirill A. Shutemov
On Fri, Dec 08, 2017 at 05:15:57PM +0100, Michal Hocko wrote: > From: Michal Hocko > > do_pages_move is supposed to move user defined memory (an array of > addresses) to the user defined numa nodes (an array of nodes one for > each address). The user provided status array then contains resulting