Re: [RFC PATCH 1/5] watchdog: Add API to trigger reboots

2014-05-07 Thread Maxime Ripard
On Wed, May 07, 2014 at 06:01:31AM -0700, Guenter Roeck wrote: > >This means we could have multiple watchdogs in the system, where we > >really want a specific one (maybe designated through a DT property) to > >do the reset. This isn't compatible with the "last watchdog that > >registers a handler

Re: [RFC PATCH 1/5] watchdog: Add API to trigger reboots

2014-05-07 Thread Lucas Stach
Am Mittwoch, den 07.05.2014, 06:01 -0700 schrieb Guenter Roeck: > On 05/07/2014 04:52 AM, Lucas Stach wrote: > > Hi Guenter, > > > > Am Freitag, den 02.05.2014, 21:29 -0700 schrieb Guenter Roeck: > >> On Fri, May 02, 2014 at 06:22:43PM -0700, Maxime Ripard wrote: > >>> Hi Guenter, > >>> > >>> On Th

Re: [RFC PATCH 1/5] watchdog: Add API to trigger reboots

2014-05-07 Thread Guenter Roeck
On 05/07/2014 04:52 AM, Lucas Stach wrote: Hi Guenter, Am Freitag, den 02.05.2014, 21:29 -0700 schrieb Guenter Roeck: On Fri, May 02, 2014 at 06:22:43PM -0700, Maxime Ripard wrote: Hi Guenter, On Thu, May 01, 2014 at 08:41:29AM -0700, Guenter Roeck wrote: Some hardware implements reboot thro

Re: [RFC PATCH 1/5] watchdog: Add API to trigger reboots

2014-05-07 Thread Lucas Stach
Hi Guenter, Am Freitag, den 02.05.2014, 21:29 -0700 schrieb Guenter Roeck: > On Fri, May 02, 2014 at 06:22:43PM -0700, Maxime Ripard wrote: > > Hi Guenter, > > > > On Thu, May 01, 2014 at 08:41:29AM -0700, Guenter Roeck wrote: > > > Some hardware implements reboot through its watchdog hardware, >

Re: [RFC PATCH 1/5] watchdog: Add API to trigger reboots

2014-05-05 Thread Guenter Roeck
On Mon, May 05, 2014 at 01:36:06PM -0500, Felipe Balbi wrote: > On Thu, May 01, 2014 at 08:41:29AM -0700, Guenter Roeck wrote: > > Some hardware implements reboot through its watchdog hardware, > > for example by triggering a watchdog timeout. Platform specific > > code starts to spread into watchd

Re: [RFC PATCH 1/5] watchdog: Add API to trigger reboots

2014-05-05 Thread Felipe Balbi
On Thu, May 01, 2014 at 08:41:29AM -0700, Guenter Roeck wrote: > Some hardware implements reboot through its watchdog hardware, > for example by triggering a watchdog timeout. Platform specific > code starts to spread into watchdog drivers, typically by setting > pointers to a callback functions wh

Re: [RFC PATCH 1/5] watchdog: Add API to trigger reboots

2014-05-04 Thread Maxime Ripard
On Fri, May 02, 2014 at 09:29:25PM -0700, Guenter Roeck wrote: > > > + if (wdd->ops->reboot) > > > + wdd_reboot_dev = wdd; > > > + > > > > Overall, it looks really great, but I guess we can make it a > > list. Otherwise, we might end up in a situation where we could not > > reboot anymore,

Re: [RFC PATCH 1/5] watchdog: Add API to trigger reboots

2014-05-02 Thread Guenter Roeck
On Fri, May 02, 2014 at 06:22:43PM -0700, Maxime Ripard wrote: > Hi Guenter, > > On Thu, May 01, 2014 at 08:41:29AM -0700, Guenter Roeck wrote: > > Some hardware implements reboot through its watchdog hardware, > > for example by triggering a watchdog timeout. Platform specific > > code starts to

Re: [RFC PATCH 1/5] watchdog: Add API to trigger reboots

2014-05-02 Thread Maxime Ripard
Hi Guenter, On Thu, May 01, 2014 at 08:41:29AM -0700, Guenter Roeck wrote: > Some hardware implements reboot through its watchdog hardware, > for example by triggering a watchdog timeout. Platform specific > code starts to spread into watchdog drivers, typically by setting > pointers to a callback

Re: [RFC PATCH 1/5] watchdog: Add API to trigger reboots

2014-05-02 Thread Guenter Roeck
On 05/02/2014 03:01 AM, Will Deacon wrote: Hi Guenter, This looks pretty sensible to me (and the arm/arm64 bits look fine too), but I have one question below... On Thu, May 01, 2014 at 04:41:29PM +0100, Guenter Roeck wrote: Some hardware implements reboot through its watchdog hardware, for exa

Re: [RFC PATCH 1/5] watchdog: Add API to trigger reboots

2014-05-02 Thread Will Deacon
Hi Guenter, This looks pretty sensible to me (and the arm/arm64 bits look fine too), but I have one question below... On Thu, May 01, 2014 at 04:41:29PM +0100, Guenter Roeck wrote: > Some hardware implements reboot through its watchdog hardware, > for example by triggering a watchdog timeout. Pla