Re: [RFC PATCH 1/6] security/fbfam: Add a Kconfig to enable the fbfam feature

2020-09-18 Thread John Wood
On Thu, Sep 17, 2020 at 03:05:18PM -0700, Kees Cook wrote: > On Thu, Sep 17, 2020 at 08:40:06PM +0200, John Wood wrote: > > > To jump on the bikeshed: how about just calling this > > > FORK_BRUTE_FORCE_DETECTION or FORK_BRUTE, and the directory could be > > > "brute", etc. "fbfam" doesn't tell anyo

Re: [RFC PATCH 1/6] security/fbfam: Add a Kconfig to enable the fbfam feature

2020-09-17 Thread Kees Cook
On Thu, Sep 17, 2020 at 08:40:06PM +0200, John Wood wrote: > Hi, > > On Thu, Sep 10, 2020 at 04:18:08PM -0700, Kees Cook wrote: > > On Thu, Sep 10, 2020 at 01:21:02PM -0700, Kees Cook wrote: > > > From: John Wood > > > > > > Add a menu entry under "Security options" to enable the "Fork brute > >

Re: [RFC PATCH 1/6] security/fbfam: Add a Kconfig to enable the fbfam feature

2020-09-17 Thread John Wood
Hi, On Thu, Sep 10, 2020 at 04:18:08PM -0700, Kees Cook wrote: > On Thu, Sep 10, 2020 at 01:21:02PM -0700, Kees Cook wrote: > > From: John Wood > > > > Add a menu entry under "Security options" to enable the "Fork brute > > force attack mitigation" feature. > > > > Signed-off-by: John Wood > > -

Re: [RFC PATCH 1/6] security/fbfam: Add a Kconfig to enable the fbfam feature

2020-09-17 Thread John Wood
On Thu, Sep 10, 2020 at 11:21:58PM +0200, Jann Horn wrote: > On Thu, Sep 10, 2020 at 10:21 PM Kees Cook wrote: > > From: John Wood > > > > Add a menu entry under "Security options" to enable the "Fork brute > > force attack mitigation" feature. > [...] > > +config FBFAM > > Please give this a mor

Re: [RFC PATCH 1/6] security/fbfam: Add a Kconfig to enable the fbfam feature

2020-09-10 Thread Kees Cook
On Thu, Sep 10, 2020 at 01:21:02PM -0700, Kees Cook wrote: > From: John Wood > > Add a menu entry under "Security options" to enable the "Fork brute > force attack mitigation" feature. > > Signed-off-by: John Wood > --- > security/Kconfig | 1 + > security/fbfam/Kconfig | 10 ++

Re: [RFC PATCH 1/6] security/fbfam: Add a Kconfig to enable the fbfam feature

2020-09-10 Thread Jann Horn
On Thu, Sep 10, 2020 at 10:21 PM Kees Cook wrote: > From: John Wood > > Add a menu entry under "Security options" to enable the "Fork brute > force attack mitigation" feature. [...] > +config FBFAM Please give this a more descriptive name than FBFAM. Some name where, if a random kernel developer