Re: [RFC PATCH 11/18] jffs2: Convert jffs2_gcd_mtd kthread into the iterant API

2015-06-06 Thread Oleg Nesterov
On 06/07, Jiri Kosina wrote: > > On Sun, 7 Jun 2015, Oleg Nesterov wrote: > > > > I personally don't see a huge principal difference between > > > "kthread_signal_dequeue() + kthread_do_signal_{stop,...}" vs. generic > > > "kthread_do_signal()" that's just basically completely general and > > > tak

Re: [RFC PATCH 11/18] jffs2: Convert jffs2_gcd_mtd kthread into the iterant API

2015-06-06 Thread Jiri Kosina
On Sun, 7 Jun 2015, Oleg Nesterov wrote: > > > Still I personally dislike the new kthread_sigaction() API. I agree, > > > a couple if signal helpers for kthreads make sense. Say, > > > > > > void kthread_do_signal_stop(void) > > > { > > > spin_lock_irq(&curtent->sighand->siglock); >

Re: [RFC PATCH 11/18] jffs2: Convert jffs2_gcd_mtd kthread into the iterant API

2015-06-06 Thread Oleg Nesterov
On 06/06, Jiri Kosina wrote: > > On Sat, 6 Jun 2015, Oleg Nesterov wrote: > > > Still I personally dislike the new kthread_sigaction() API. I agree, > > a couple if signal helpers for kthreads make sense. Say, > > > > void kthread_do_signal_stop(void) > > { > > spin_lock_irq(&cu

Re: [RFC PATCH 11/18] jffs2: Convert jffs2_gcd_mtd kthread into the iterant API

2015-06-06 Thread Jiri Kosina
On Sat, 6 Jun 2015, Oleg Nesterov wrote: > Still I personally dislike the new kthread_sigaction() API. I agree, > a couple if signal helpers for kthreads make sense. Say, > > void kthread_do_signal_stop(void) > { > spin_lock_irq(&curtent->sighand->siglock); >

Re: [RFC PATCH 11/18] jffs2: Convert jffs2_gcd_mtd kthread into the iterant API

2015-06-06 Thread Oleg Nesterov
On 06/05, Petr Mladek wrote: > > [*] In fact, there was a bug in the original code. It tried to process > a non-existing signal when the system was freezing. See the common > check for pending signal and freezing. And another bug afaics: > - case SIGSTOP: > -