Re: [RFC PATCH 2/2] mm, mempool: do not throttle PF_LESS_THROTTLE tasks

2016-07-26 Thread Michal Hocko
On Mon 25-07-16 17:52:17, Mikulas Patocka wrote: > > > On Sat, 23 Jul 2016, NeilBrown wrote: > > > "dirtying ... from the reclaim context" ??? What does that mean? > > According to > > Commit: 26eecbf3543b ("[PATCH] vm: pageout throttling") > > From the history tree, the purpose of throttle_vm

Re: [RFC PATCH 2/2] mm, mempool: do not throttle PF_LESS_THROTTLE tasks

2016-07-26 Thread Michal Hocko
On Mon 25-07-16 21:23:44, Michal Hocko wrote: > [CC Marcelo who might remember other details for the loads which made > him to add this code - see the patch changelog for more context] > > On Mon 25-07-16 10:32:47, Michal Hocko wrote: [...] > From 0d950d64e3c59061f7cca71fe5877d4e430499c9 Mon Sep

Re: [RFC PATCH 2/2] mm, mempool: do not throttle PF_LESS_THROTTLE tasks

2016-07-25 Thread Mikulas Patocka
On Sat, 23 Jul 2016, NeilBrown wrote: > "dirtying ... from the reclaim context" ??? What does that mean? > According to > Commit: 26eecbf3543b ("[PATCH] vm: pageout throttling") > From the history tree, the purpose of throttle_vm_writeout() is to > limit the amount of memory that is concurrent

Re: [RFC PATCH 2/2] mm, mempool: do not throttle PF_LESS_THROTTLE tasks

2016-07-25 Thread Michal Hocko
[CC Marcelo who might remember other details for the loads which made him to add this code - see the patch changelog for more context] On Mon 25-07-16 10:32:47, Michal Hocko wrote: > On Sat 23-07-16 10:12:24, NeilBrown wrote: [...] > > So I wonder what throttle_vm_writeout() really achieves these

Re: [RFC PATCH 2/2] mm, mempool: do not throttle PF_LESS_THROTTLE tasks

2016-07-25 Thread Michal Hocko
On Sat 23-07-16 10:12:24, NeilBrown wrote: > On Fri, Jul 22 2016, Michal Hocko wrote: [...] > > If we just back off and rely on kswapd which > > might get stuck on the writeout then the IO throughput can be reduced > > If I were king of MM, I would make a decree to be proc

Re: [RFC PATCH 2/2] mm, mempool: do not throttle PF_LESS_THROTTLE tasks

2016-07-22 Thread NeilBrown
On Fri, Jul 22 2016, Michal Hocko wrote: > On Fri 22-07-16 18:46:57, Neil Brown wrote: >> On Mon, Jul 18 2016, Michal Hocko wrote: >> >> > From: Michal Hocko >> > >> > Mikulas has reported that a swap backed by dm-crypt doesn't work >> > properly because the swapout cannot make a sufficient forw

Re: [RFC PATCH 2/2] mm, mempool: do not throttle PF_LESS_THROTTLE tasks

2016-07-22 Thread Michal Hocko
On Fri 22-07-16 18:46:57, Neil Brown wrote: > On Mon, Jul 18 2016, Michal Hocko wrote: > > > From: Michal Hocko > > > > Mikulas has reported that a swap backed by dm-crypt doesn't work > > properly because the swapout cannot make a sufficient forward progress > > as the writeout path depends on d

Re: [RFC PATCH 2/2] mm, mempool: do not throttle PF_LESS_THROTTLE tasks

2016-07-22 Thread NeilBrown
On Fri, Jul 22 2016, NeilBrown wrote: > > Looking at the current code, __GFP_DIRECT_RECLAIM is disabled the first > time through, but if the pool is empty, direct-reclaim is allowed on the > next attempt. Presumably this is where the throttling comes in ?? I > suspect that it really shouldn't do

Re: [RFC PATCH 2/2] mm, mempool: do not throttle PF_LESS_THROTTLE tasks

2016-07-22 Thread NeilBrown
On Mon, Jul 18 2016, Michal Hocko wrote: > From: Michal Hocko > > Mikulas has reported that a swap backed by dm-crypt doesn't work > properly because the swapout cannot make a sufficient forward progress > as the writeout path depends on dm_crypt worker which has to allocate > memory to perform t

Re: [RFC PATCH 2/2] mm, mempool: do not throttle PF_LESS_THROTTLE tasks

2016-07-19 Thread Mikulas Patocka
On Mon, 18 Jul 2016, Michal Hocko wrote: > From: Michal Hocko > > Mikulas has reported that a swap backed by dm-crypt doesn't work > properly because the swapout cannot make a sufficient forward progress > as the writeout path depends on dm_crypt worker which has to allocate > memory to perfor