Re: [RFC PATCH 2/3] regulator: max77686: Add support for various operating modes

2012-12-11 Thread Abhilash Kesavan
On Tue, Dec 11, 2012 at 6:27 PM, Mark Brown wrote: > On Mon, Dec 10, 2012 at 02:06:49PM +0530, Abhilash Kesavan wrote: >> On Mon, Dec 10, 2012 at 1:49 PM, Abhilash Kesavan >> wrote: > >> > Mark Brown opensource.wolfsonmicro.com> writes: > >> >> Binding documenation is mandatory for any new OF pr

Re: [RFC PATCH 2/3] regulator: max77686: Add support for various operating modes

2012-12-11 Thread Mark Brown
On Mon, Dec 10, 2012 at 02:06:49PM +0530, Abhilash Kesavan wrote: > On Mon, Dec 10, 2012 at 1:49 PM, Abhilash Kesavan > wrote: > > Mark Brown opensource.wolfsonmicro.com> writes: > >> Binding documenation is mandatory for any new OF properties, please add > >> this. > > Patch 3/3 of this serie

Re: [RFC PATCH 2/3] regulator: max77686: Add support for various operating modes

2012-12-10 Thread Abhilash Kesavan
Adding missed Cc's On Mon, Dec 10, 2012 at 1:49 PM, Abhilash Kesavan wrote: > Mark Brown opensource.wolfsonmicro.com> writes: > > [...] >> Binding documenation is mandatory for any new OF properties, please add >> this. > Patch 3/3 of this series adds documentation for the max77686-opmode proper

Re: [RFC PATCH 2/3] regulator: max77686: Add support for various operating modes

2012-12-10 Thread Abhilash Kesavan
Mark Brown opensource.wolfsonmicro.com> writes: [...] > Binding documenation is mandatory for any new OF properties, please add > this. Patch 3/3 of this series adds documentation for the max77686-opmode property. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [RFC PATCH 2/3] regulator: max77686: Add support for various operating modes

2012-12-09 Thread Mark Brown
On Mon, Dec 10, 2012 at 11:56:23AM +0530, Abhilash Kesavan wrote: > + if (of_property_read_u32(rdata[i].of_node, "max77686-opmode", > + &rdata[i].opmode)) { > + dev_warn(iodev->dev, "no op_mode property property at > %s\n", > +