Re: [RFC PATCH 2/4] pmbus: Add fan configuration support

2017-07-12 Thread Guenter Roeck
On Wed, Jul 12, 2017 at 04:31:09PM +0930, Andrew Jeffery wrote: > > Indeed. Hence RFC in case I had overlooked something :) Clearly I have. > Not surprising. It isn't exceptionally well documented :-) > > > > > However, the addition of the callbacks was driven by the behaviour of > > > the MAX3

Re: [RFC PATCH 2/4] pmbus: Add fan configuration support

2017-07-12 Thread Andrew Jeffery
On Tue, 2017-07-11 at 20:43 -0700, Guenter Roeck wrote: > On 07/11/2017 05:39 PM, Andrew Jeffery wrote: > > On Tue, 2017-07-11 at 06:40 -0700, Guenter Roeck wrote: > > > On 07/10/2017 06:56 AM, Andrew Jeffery wrote: > > > > Augment PMBus support to include control of fans via the > > > > FAN_COMMAN

Re: [RFC PATCH 2/4] pmbus: Add fan configuration support

2017-07-11 Thread Guenter Roeck
On 07/11/2017 05:39 PM, Andrew Jeffery wrote: On Tue, 2017-07-11 at 06:40 -0700, Guenter Roeck wrote: On 07/10/2017 06:56 AM, Andrew Jeffery wrote: Augment PMBus support to include control of fans via the FAN_COMMAND_[1-4] registers, both in RPM and PWM modes. The behaviour of FAN_CONFIG_{1_2,3

Re: [RFC PATCH 2/4] pmbus: Add fan configuration support

2017-07-11 Thread Andrew Jeffery
On Tue, 2017-07-11 at 06:40 -0700, Guenter Roeck wrote: > On 07/10/2017 06:56 AM, Andrew Jeffery wrote: > > Augment PMBus support to include control of fans via the > > FAN_COMMAND_[1-4] registers, both in RPM and PWM modes. The behaviour > > of FAN_CONFIG_{1_2,3_4} and FAN_COMMAND_[1-4] are tightl

Re: [RFC PATCH 2/4] pmbus: Add fan configuration support

2017-07-11 Thread Guenter Roeck
On 07/10/2017 06:56 AM, Andrew Jeffery wrote: Augment PMBus support to include control of fans via the FAN_COMMAND_[1-4] registers, both in RPM and PWM modes. The behaviour of FAN_CONFIG_{1_2,3_4} and FAN_COMMAND_[1-4] are tightly coupled, and their interactions do not fit the existing use of str