Re: [RFC PATCH 3/3] i915: Expose PMU for Observation Architecture

2014-10-23 Thread Chris Wilson
On Fri, Oct 24, 2014 at 03:33:14AM +0100, Robert Bragg wrote: > On Thu, Oct 23, 2014 at 8:47 AM, Chris Wilson > wrote: > > On Wed, Oct 22, 2014 at 04:28:51PM +0100, Robert Bragg wrote: > >> + /* XXX: Not sure that this is really acceptable... > >> + * > >> + * i915_gem_context.c cur

Re: [RFC PATCH 3/3] i915: Expose PMU for Observation Architecture

2014-10-23 Thread Robert Bragg
On Thu, Oct 23, 2014 at 8:47 AM, Chris Wilson wrote: > On Wed, Oct 22, 2014 at 04:28:51PM +0100, Robert Bragg wrote: >> + /* XXX: Not sure that this is really acceptable... >> + * >> + * i915_gem_context.c currently owns pinning/unpinning legacy >> + * context buffers and althou

Re: [RFC PATCH 3/3] i915: Expose PMU for Observation Architecture

2014-10-23 Thread Chris Wilson
On Wed, Oct 22, 2014 at 04:28:51PM +0100, Robert Bragg wrote: > + /* XXX: Not sure that this is really acceptable... > + * > + * i915_gem_context.c currently owns pinning/unpinning legacy > + * context buffers and although that code has a > + * get_context_alignment() func t