Re: [RFC PATCH 3/6] bpf: Save the pointer to struct perf_event to map

2015-07-17 Thread Wangnan (F)
On 2015/7/17 20:02, Peter Zijlstra wrote: On Fri, Jul 17, 2015 at 07:54:55PM +0800, Wangnan (F) wrote: Thanks. In next version we will introduce a new function which do oppsite thing to perf_event_release_kernel() in perf/event/core.c, then fetch the event before fdput. perf_event_get() as pr

Re: [RFC PATCH 3/6] bpf: Save the pointer to struct perf_event to map

2015-07-17 Thread Peter Zijlstra
On Fri, Jul 17, 2015 at 07:54:55PM +0800, Wangnan (F) wrote: > Thanks. In next version we will introduce a new function which do oppsite > thing to > perf_event_release_kernel() in perf/event/core.c, then fetch the event > before fdput. perf_event_get() as proposed, with the addition of the refcou

Re: [RFC PATCH 3/6] bpf: Save the pointer to struct perf_event to map

2015-07-17 Thread Wangnan (F)
On 2015/7/17 19:40, Peter Zijlstra wrote: On Fri, Jul 17, 2015 at 07:34:22PM +0800, Wangnan (F) wrote: On 2015/7/17 19:21, Wangnan (F) wrote: On 2015/7/17 19:06, Peter Zijlstra wrote: On Fri, Jul 17, 2015 at 06:43:33PM +0800, kaixu xia wrote: diff --git a/kernel/events/core.c b/kernel/event

Re: [RFC PATCH 3/6] bpf: Save the pointer to struct perf_event to map

2015-07-17 Thread Peter Zijlstra
On Fri, Jul 17, 2015 at 07:34:22PM +0800, Wangnan (F) wrote: > On 2015/7/17 19:21, Wangnan (F) wrote: > >On 2015/7/17 19:06, Peter Zijlstra wrote: > >>On Fri, Jul 17, 2015 at 06:43:33PM +0800, kaixu xia wrote: > >>>diff --git a/kernel/events/core.c b/kernel/events/core.c > >>>index e965cfa..c4e34b7

Re: [RFC PATCH 3/6] bpf: Save the pointer to struct perf_event to map

2015-07-17 Thread Peter Zijlstra
On Fri, Jul 17, 2015 at 06:43:33PM +0800, kaixu xia wrote: > +static int replace_map_with_perf_event(void *value) > +{ > + struct perf_event *event; > + u32 fd; > + > + fd = *(u32 *)value; > + > + event = perf_event_get(fd); > + if (IS_ERR(event)) > + return PTR_ERR(

Re: [RFC PATCH 3/6] bpf: Save the pointer to struct perf_event to map

2015-07-17 Thread Wangnan (F)
On 2015/7/17 19:21, Wangnan (F) wrote: On 2015/7/17 19:06, Peter Zijlstra wrote: On Fri, Jul 17, 2015 at 06:43:33PM +0800, kaixu xia wrote: diff --git a/kernel/events/core.c b/kernel/events/core.c index e965cfa..c4e34b7 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -8582,6

Re: [RFC PATCH 3/6] bpf: Save the pointer to struct perf_event to map

2015-07-17 Thread Wangnan (F)
On 2015/7/17 19:06, Peter Zijlstra wrote: On Fri, Jul 17, 2015 at 06:43:33PM +0800, kaixu xia wrote: diff --git a/kernel/events/core.c b/kernel/events/core.c index e965cfa..c4e34b7 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -8582,6 +8582,28 @@ void perf_event_delayed_put(s

Re: [RFC PATCH 3/6] bpf: Save the pointer to struct perf_event to map

2015-07-17 Thread Peter Zijlstra
On Fri, Jul 17, 2015 at 06:43:33PM +0800, kaixu xia wrote: > diff --git a/kernel/events/core.c b/kernel/events/core.c > index e965cfa..c4e34b7 100644 > --- a/kernel/events/core.c > +++ b/kernel/events/core.c > @@ -8582,6 +8582,28 @@ void perf_event_delayed_put(struct task_struct *task) >