Re: [RFC PATCH 5/17] input: rmidev character driver for RMI4 sensors

2012-09-05 Thread Linus Walleij
On Wed, Sep 5, 2012 at 2:26 AM, Christopher Heiny wrote: > On 08/27/2012 11:49 AM, Linus Walleij wrote: >> >> You need to patch your desired major number into >> Documentation/devices.txt' > > We were going by the recommendation in Linux Device Drivers (3rd edition) to > use dynamic major number a

Re: [RFC PATCH 5/17] input: rmidev character driver for RMI4 sensors

2012-09-04 Thread Christopher Heiny
On 08/27/2012 11:49 AM, Linus Walleij wrote: On Fri, Aug 17, 2012 at 3:17 PM, Christopher Heiny wrote: Driver for Synaptics touchscreens using RMI4 protocol. Really? This looks more like some custom char driver to get a pipe into the device from userspace. Put in a proper description of what

Re: [RFC PATCH 5/17] input: rmidev character driver for RMI4 sensors

2012-08-27 Thread Linus Walleij
On Fri, Aug 17, 2012 at 3:17 PM, Christopher Heiny wrote: > Driver for Synaptics touchscreens using RMI4 protocol. Really? This looks more like some custom char driver to get a pipe into the device from userspace. Put in a proper description of what this is for. If the purpose is to read/write