Re: [RFC PATCH V2] rt/aio: fix rcu garbage collection might_sleep() splat

2015-02-16 Thread Sebastian Andrzej Siewior
* Benjamin LaHaise | 2014-06-25 11:24:45 [-0400]: >I finally have some time to look at this patch in detail. I'd rather do the >below variant that does what Kent suggested. Mike, can you confirm that >this fixes the issue you reported? It's on top of my current aio-next tree >at git://git.kv

Re: [RFC PATCH V2] rt/aio: fix rcu garbage collection might_sleep() splat

2014-06-26 Thread Benjamin LaHaise
On Thu, Jun 26, 2014 at 09:37:14AM +0200, Mike Galbraith wrote: > Hi Ben, > > On Wed, 2014-06-25 at 11:24 -0400, Benjamin LaHaise wrote: > > > I finally have some time to look at this patch in detail. I'd rather do > > the > > below variant that does what Kent suggested. Mike, can you confirm

Re: [RFC PATCH V2] rt/aio: fix rcu garbage collection might_sleep() splat

2014-06-26 Thread Mike Galbraith
Hi Ben, On Wed, 2014-06-25 at 11:24 -0400, Benjamin LaHaise wrote: > I finally have some time to look at this patch in detail. I'd rather do the > below variant that does what Kent suggested. Mike, can you confirm that > this fixes the issue you reported? It's on top of my current aio-next t

Re: [RFC PATCH V2] rt/aio: fix rcu garbage collection might_sleep() splat

2014-06-25 Thread Benjamin LaHaise
On Thu, Jun 12, 2014 at 01:26:02PM -0700, Kent Overstreet wrote: > On Tue, Jun 10, 2014 at 01:50:01PM -0400, Benjamin LaHaise wrote: > > On Tue, Jun 10, 2014 at 05:47:28AM +0200, Mike Galbraith wrote: > > > On Mon, 2014-06-09 at 10:08 +0800, Lai Jiangshan wrote: > > > > Hi, rt-people > > > > > >

Re: [RFC PATCH V2] rt/aio: fix rcu garbage collection might_sleep() splat

2014-06-12 Thread Kent Overstreet
On Tue, Jun 10, 2014 at 01:50:01PM -0400, Benjamin LaHaise wrote: > On Tue, Jun 10, 2014 at 05:47:28AM +0200, Mike Galbraith wrote: > > On Mon, 2014-06-09 at 10:08 +0800, Lai Jiangshan wrote: > > > Hi, rt-people > > > > > > I don't think it is the correct direction. > > > Softirq (including local

Re: [RFC PATCH V2] rt/aio: fix rcu garbage collection might_sleep() splat

2014-06-10 Thread Mike Galbraith
On Tue, 2014-06-10 at 13:50 -0400, Benjamin LaHaise wrote: > On Tue, Jun 10, 2014 at 05:47:28AM +0200, Mike Galbraith wrote: > > On Mon, 2014-06-09 at 10:08 +0800, Lai Jiangshan wrote: > > > Hi, rt-people > > > > > > I don't think it is the correct direction. > > > Softirq (including local_bh_di

Re: [RFC PATCH V2] rt/aio: fix rcu garbage collection might_sleep() splat

2014-06-10 Thread Benjamin LaHaise
On Tue, Jun 10, 2014 at 05:47:28AM +0200, Mike Galbraith wrote: > On Mon, 2014-06-09 at 10:08 +0800, Lai Jiangshan wrote: > > Hi, rt-people > > > > I don't think it is the correct direction. > > Softirq (including local_bh_disable()) in RT kernel should be preemptible. > > How about the below th