RE: [RFC PATCH v2 3/5] scsi: ufs: Introduce HPB module

2020-06-17 Thread Avri Altman
> > > > > implemented > > > > > as a module parameter, so that it can be configurable by the > > > > > user. > > > > > > > > > > To gurantee a minimum memory pool size of 4MB: > > > > > $ insmod ufshpb.ko ufshpb_host_map_kbytes=4096 > > > > > > > > You are going through a lot of troubles to make

RE: [RFC PATCH v2 3/5] scsi: ufs: Introduce HPB module

2020-06-17 Thread Daejun Park
> +static int ufshpb_lu_hpb_init(struct ufs_hba *hba, struct ufshpb_lu *hpb, > > + struct ufshpb_dev_info *hpb_dev_info) > > +{ > > + int ret; > > + > > + spin_lock_init(&hpb->hpb_state_lock); > > + > > + ret = ufshpb_alloc_region_tbl(hba, hpb); > > +

Re: [RFC PATCH v2 3/5] scsi: ufs: Introduce HPB module

2020-06-17 Thread Daejun Park
> > > implemented > > > > as a module parameter, so that it can be configurable by the > > > > user. > > > > > > > > To gurantee a minimum memory pool size of 4MB: > > > > $ insmod ufshpb.ko ufshpb_host_map_kbytes=4096 > > > > > > You are going through a lot of troubles to make it a loadable > >

Re: [RFC PATCH v2 3/5] scsi: ufs: Introduce HPB module

2020-06-17 Thread Bean Huo
On Wed, 2020-06-17 at 19:30 +0900, Daejun Park wrote: > > > implemented > > > as a module parameter, so that it can be configurable by the > > > user. > > > > > > To gurantee a minimum memory pool size of 4MB: > > > $ insmod ufshpb.ko ufshpb_host_map_kbytes=4096 > > > > You are going through a lo

RE: [RFC PATCH v2 3/5] scsi: ufs: Introduce HPB module

2020-06-17 Thread Daejun Park
> > > This is a patch for the HPB module. > > The HPB module queries UFS for device information during initialization. > > We added the export symbol to two functions in ufshcd.c to initialize > > the HPB module. > > > > The HPB module can be loaded or built-in as needed. > > The mininum size of

RE: [RFC PATCH v2 3/5] scsi: ufs: Introduce HPB module

2020-06-17 Thread Avri Altman
> +static int ufshpb_lu_hpb_init(struct ufs_hba *hba, struct ufshpb_lu *hpb, > + struct ufshpb_dev_info *hpb_dev_info) > +{ > + int ret; > + > + spin_lock_init(&hpb->hpb_state_lock); > + > + ret = ufshpb_alloc_region_tbl(hba, hpb); > + if (ret) >

RE: [RFC PATCH v2 3/5] scsi: ufs: Introduce HPB module

2020-06-17 Thread Avri Altman
> > This is a patch for the HPB module. > The HPB module queries UFS for device information during initialization. > We added the export symbol to two functions in ufshcd.c to initialize > the HPB module. > > The HPB module can be loaded or built-in as needed. > The mininum size of the memory p