Re: [RFC PATCH v2 4/9] crypto: qce: Add ablkcipher algorithms

Thanks for the review! On 04/28/2014 11:18 AM, Herbert Xu wrote: > On Mon, Apr 14, 2014 at 03:48:40PM +0300, Stanimir Varbanov wrote: >> >> +} else if (IS_DES(flags)) { >> +u32 tmp[DES_EXPKEY_WORDS]; >> + >> +if (keylen != QCE_DES_KEY_SIZE) >> +goto

Re: [RFC PATCH v2 4/9] crypto: qce: Add ablkcipher algorithms

Thanks for the review! On 04/28/2014 11:00 AM, Herbert Xu wrote: > On Mon, Apr 14, 2014 at 03:48:40PM +0300, Stanimir Varbanov wrote: >> >> +if (IS_AES(flags)) { >> +switch (keylen) { >> +case AES_KEYSIZE_128: >> +case AES_KEYSIZE_256: >> +

Re: [RFC PATCH v2 4/9] crypto: qce: Add ablkcipher algorithms

On Mon, Apr 14, 2014 at 03:48:40PM +0300, Stanimir Varbanov wrote: > > + } else if (IS_DES(flags)) { > + u32 tmp[DES_EXPKEY_WORDS]; > + > + if (keylen != QCE_DES_KEY_SIZE) > + goto badkey; No need to check here since you've already set min_keysize an

Re: [RFC PATCH v2 4/9] crypto: qce: Add ablkcipher algorithms

On Mon, Apr 14, 2014 at 03:48:40PM +0300, Stanimir Varbanov wrote: > > + if (IS_AES(flags)) { > + switch (keylen) { > + case AES_KEYSIZE_128: > + case AES_KEYSIZE_256: > + break; > + default: > + goto badkey