RE: [RFC PATCH v3] edac: synps: Added EDAC support for zynq ddr ecc controller

2014-07-31 Thread Punnaiah Choudary Kalluri
cet...@hellion.org.uk; Kumar Gala; Rob Landley; >devicet...@vger.kernel.org; linux-...@vger.kernel.org; linux- >e...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- >ker...@lists.infradead.org; Punnaiah Choudary; Anirudha Sarangi; Srikanth >Vemula >Subject: Re: [RFC PATCH v3]

Re: [RFC PATCH v3] edac: synps: Added EDAC support for zynq ddr ecc controller

2014-07-31 Thread Borislav Petkov
On Thu, Jul 31, 2014 at 03:36:35PM +0200, Michal Simek wrote: > Mixing functions for two/more different controller seems to me > really messy. Just stating that something is "really messy" without giving at least one technical reason for it is not going to get you any further. So let me give you m

Re: [RFC PATCH v3] edac: synps: Added EDAC support for zynq ddr ecc controller

2014-07-31 Thread Michal Simek
On 07/31/2014 03:17 PM, Borislav Petkov wrote: > On Thu, Jul 31, 2014 at 02:13:48PM +0200, Michal Simek wrote: >> Mixing two drivers in the one file is not a good idea because with >> more memory controllers it is just a mess and you are not able to >> cover all cases. > > Why is it a mess? Mixin

Re: [RFC PATCH v3] edac: synps: Added EDAC support for zynq ddr ecc controller

2014-07-31 Thread Borislav Petkov
On Thu, Jul 31, 2014 at 02:13:48PM +0200, Michal Simek wrote: > Mixing two drivers in the one file is not a good idea because with > more memory controllers it is just a mess and you are not able to > cover all cases. Why is it a mess? > If this is just about providing uniq number we can easily e

Re: [RFC PATCH v3] edac: synps: Added EDAC support for zynq ddr ecc controller

2014-07-31 Thread Michal Simek
On 07/31/2014 01:33 PM, Borislav Petkov wrote: > On Wed, Jul 30, 2014 at 03:41:47PM +, Punnaiah Choudary Kalluri wrote: >>> So you're telling me that you want one edac driver for *two* memory >>> controllers which can be present on a single system *at* *the* *same* >>> *time*? Is that it? >> >>

Re: [RFC PATCH v3] edac: synps: Added EDAC support for zynq ddr ecc controller

2014-07-31 Thread Borislav Petkov
On Wed, Jul 30, 2014 at 03:41:47PM +, Punnaiah Choudary Kalluri wrote: > >So you're telling me that you want one edac driver for *two* memory > >controllers which can be present on a single system *at* *the* *same* > >*time*? Is that it? > > Yes. Oh, this'll be fun. :-P > > > >How exactly is

Re: [RFC PATCH v3] edac: synps: Added EDAC support for zynq ddr ecc controller

2014-07-31 Thread Michal Simek
rnel.org; linux-arm- >> ker...@lists.infradead.org; Punnaiah Choudary; Anirudha Sarangi; Srikanth >> Vemula >> Subject: Re: [RFC PATCH v3] edac: synps: Added EDAC support for zynq ddr >> ecc controller >> >> On Mon, Jul 28, 2014 at 10:53:26PM +0530, punn

RE: [RFC PATCH v3] edac: synps: Added EDAC support for zynq ddr ecc controller

2014-07-30 Thread Punnaiah Choudary Kalluri
ject: Re: [RFC PATCH v3] edac: synps: Added EDAC support for zynq ddr >ecc controller > >On Mon, Jul 28, 2014 at 10:53:26PM +0530, punnaiah choudary kalluri wrote: >> I can agree with you that we can use shorter names.But ZYNQ has >> programmable logic next to processing syste

Re: [RFC PATCH v3] edac: synps: Added EDAC support for zynq ddr ecc controller

2014-07-28 Thread Borislav Petkov
On Mon, Jul 28, 2014 at 10:53:26PM +0530, punnaiah choudary kalluri wrote: > I can agree with you that we can use shorter names.But ZYNQ has > programmable logic next to processing system where one can add soft > memory controller in the same system and may use different driver. So, > the edac driv

Re: [RFC PATCH v3] edac: synps: Added EDAC support for zynq ddr ecc controller

2014-07-28 Thread punnaiah choudary kalluri
Hi Boris, On Mon, Jul 28, 2014 at 5:04 PM, Borislav Petkov wrote: > On Sun, Jul 27, 2014 at 12:10:52AM +0530, Punnaiah Choudary Kalluri wrote: >> Added EDAC support for reporting the ecc errors of synopsys ddr controller. >> The ddr ecc controller corrects single bit errors and detects double bit

Re: [RFC PATCH v3] edac: synps: Added EDAC support for zynq ddr ecc controller

2014-07-28 Thread Borislav Petkov
On Sun, Jul 27, 2014 at 12:10:52AM +0530, Punnaiah Choudary Kalluri wrote: > Added EDAC support for reporting the ecc errors of synopsys ddr controller. > The ddr ecc controller corrects single bit errors and detects double bit > errors. > > Signed-off-by: Punnaiah Choudary Kalluri > --- > Change