Re: [RFC PATCH v3 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

2021-01-31 Thread Jonathan Cameron
On Fri, 29 Jan 2021 14:50:20 -0800 Jyoti Bhayana wrote: > Hi Peter, > > I have modified the comments in v4 of that patch. Regarding your > suggestion of this driver handling a greater value range > by adjusting the scale accordingly, it would also require the driver > to change the sensor readin

Re: [RFC PATCH v3 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

2021-01-31 Thread Jonathan Cameron
On Sat, 30 Jan 2021 21:21:41 + Cristian Marussi wrote: > Hi Jyoti, > > On Fri, Jan 29, 2021 at 02:43:13PM -0800, Jyoti Bhayana wrote: > > Hi Christian, > > > > I have addressed your feedback in v4 of the patch. Please find below > > the answers to some of your questions: > > >The init

Re: [RFC PATCH v3 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

2021-01-30 Thread Cristian Marussi
Hi Jyoti, On Fri, Jan 29, 2021 at 02:43:13PM -0800, Jyoti Bhayana wrote: > Hi Christian, > > I have addressed your feedback in v4 of the patch. Please find below > the answers to some of your questions: > >The initial sensor_config ORed here is NOT initialized nor zeroed. > > There is no

Re: [RFC PATCH v3 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

2021-01-29 Thread Jyoti Bhayana
Hi Peter, I have modified the comments in v4 of that patch. Regarding your suggestion of this driver handling a greater value range by adjusting the scale accordingly, it would also require the driver to change the sensor readings as well based on the updated scale and the accuracy of the sensor r

Re: [RFC PATCH v3 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

2021-01-29 Thread Jyoti Bhayana
Hi Christian, I have addressed your feedback in v4 of the patch. Please find below the answers to some of your questions: >The initial sensor_config ORed here is NOT initialized nor zeroed. There is no need to initialize as it is already initialized to 0 when defined. > being not so famil

Re: [RFC PATCH v3 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

2021-01-26 Thread Peter Hilber
On 22.01.21 00:21, Jyoti Bhayana wrote: > + > +static int scmi_iio_get_sensor_max_range(struct iio_dev *iio_dev, int *val, > + int *val2) > +{ > + struct scmi_iio_priv *sensor = iio_priv(iio_dev); > + int max_range_high, max_range_low; > + long lo

Re: [RFC PATCH v3 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

2021-01-22 Thread Cristian Marussi
Hi Jyoti, a few remarks below. On Thu, Jan 21, 2021 at 11:21:47PM +, Jyoti Bhayana wrote: > This change provides ARM SCMI Protocol based IIO device. > This driver provides support for Accelerometer and Gyroscope using > new SCMI Sensor Protocol defined by the upcoming SCMIv3.0 I'd say: new