Re: [RFC PATCH v4 1/4] KEYS: special dot prefixed keyring name bug fix

2014-05-30 Thread Dmitry Kasatkin
On 30 May 2014 22:12, Mimi Zohar wrote: > On Fri, 2014-05-30 at 21:24 +0300, Dmitry Kasatkin wrote: >> On 30 May 2014 20:58, "Mimi Zohar" wrote: >> > >> > On Fri, 2014-05-30 at 18:58 +0300, Dmitry Kasatkin wrote: >> > > On 28 May 2014 18:09, Mimi Zohar wrote: >> > > > Dot prefixed keyring names

Re: [RFC PATCH v4 1/4] KEYS: special dot prefixed keyring name bug fix

2014-05-30 Thread Mimi Zohar
On Fri, 2014-05-30 at 21:24 +0300, Dmitry Kasatkin wrote: > On 30 May 2014 20:58, "Mimi Zohar" wrote: > > > > On Fri, 2014-05-30 at 18:58 +0300, Dmitry Kasatkin wrote: > > > On 28 May 2014 18:09, Mimi Zohar wrote: > > > > Dot prefixed keyring names are supposed to be reserved for the > > > > ker

Re: [RFC PATCH v4 1/4] KEYS: special dot prefixed keyring name bug fix

2014-05-30 Thread Mimi Zohar
On Fri, 2014-05-30 at 18:58 +0300, Dmitry Kasatkin wrote: > On 28 May 2014 18:09, Mimi Zohar wrote: > > Dot prefixed keyring names are supposed to be reserved for the > > kernel, but add_key() calls key_get_type_from_user(), which > > incorrectly verifies the 'type' field, not the 'description' f

Re: [RFC PATCH v4 1/4] KEYS: special dot prefixed keyring name bug fix

2014-05-30 Thread Dmitry Kasatkin
On 28 May 2014 18:09, Mimi Zohar wrote: > Dot prefixed keyring names are supposed to be reserved for the > kernel, but add_key() calls key_get_type_from_user(), which > incorrectly verifies the 'type' field, not the 'description' field. > This patch verifies the 'description' field isn't dot prefi