Re: [RFC ebeam PATCH v2 3/3] input: misc: New USB eBeam input driver.

2012-08-13 Thread Jiri Kosina
On Fri, 3 Aug 2012, Yann Cantin wrote: > >> +#include > > > > As this driver is not a HID bus driver, why do you need this include? > > Cinder, removed > > >> +#define DRIVER_VERSION"v0.7" > > > > I don't think we need to be tracking driver versions for newly submitted > > drivers, git i

Re: [RFC ebeam PATCH v2 3/3] input: misc: New USB eBeam input driver.

2012-08-03 Thread Yann Cantin
Hi, >> +#include > > As this driver is not a HID bus driver, why do you need this include? Cinder, removed >> +#define DRIVER_VERSION "v0.7" > > I don't think we need to be tracking driver versions for newly submitted > drivers, git is much better at tracking changes. Old habit, remove

Re: [RFC ebeam PATCH v2 3/3] input: misc: New USB eBeam input driver.

2012-08-03 Thread Jiri Kosina
On Thu, 2 Aug 2012, Yann Cantin wrote: > Signed-off-by: Yann Cantin > --- > drivers/input/misc/Kconfig | 16 + > drivers/input/misc/Makefile |1 + > drivers/input/misc/ebeam.c | 760 > +++ > 3 files changed, 777 insertions(+) > create mode 10064