RE: [RFC v1 1/9] KVM: x86: Add base address parameter for get_fixed_pmc function

2019-08-29 Thread Kang, Luwei
> > /* returns fixed PMC with the specified MSR */ -static inline struct > > kvm_pmc *get_fixed_pmc(struct kvm_pmu *pmu, u32 msr) > > +static inline struct kvm_pmc *get_fixed_pmc(struct kvm_pmu *pmu, u32 > msr, > > + int base) > > Better d

RE: [RFC v1 1/9] KVM: x86: Add base address parameter for get_fixed_pmc function

2019-08-29 Thread Kang, Luwei
> > PEBS output Inte PT introduces some new MSRs (MSR_RELOAD_FIXED_CTRx) > > for fixed function counters that use for autoload the preset value > > after writing out a PEBS event. > > > > Introduce base MSRs address parameter to make this function can get > > performance monitor counter structure b

Re: [RFC v1 1/9] KVM: x86: Add base address parameter for get_fixed_pmc function

2019-08-29 Thread Andi Kleen
> /* returns fixed PMC with the specified MSR */ > -static inline struct kvm_pmc *get_fixed_pmc(struct kvm_pmu *pmu, u32 msr) > +static inline struct kvm_pmc *get_fixed_pmc(struct kvm_pmu *pmu, u32 msr, > + int base) Better define a __ge

Re: [RFC v1 1/9] KVM: x86: Add base address parameter for get_fixed_pmc function

2019-08-29 Thread Jim Mattson
On Wed, Aug 28, 2019 at 10:38 PM Luwei Kang wrote: > > PEBS output Inte PT introduces some new MSRs (MSR_RELOAD_FIXED_CTRx) > for fixed function counters that use for autoload the preset value > after writing out a PEBS event. > > Introduce base MSRs address parameter to make this function can get