Re: [RFC v2 2/3] drivers: nvmem: Add QTI qfprom-efuse support

2020-06-17 Thread Doug Anderson
Hi, On Sat, Jun 13, 2020 at 1:33 PM Doug Anderson wrote: > > In general I'm happy to post my series to the list myself to get > review feedback. For now I'm expecting that you can squash my changes > in and send the next version. I talked with Ravi offline and he suggested that I send out the v

Re: [RFC v2 2/3] drivers: nvmem: Add QTI qfprom-efuse support

2020-06-15 Thread Doug Anderson
Hi, On Mon, Jun 15, 2020 at 3:44 AM Srinivas Kandagatla wrote: > > > * Reading should still read "corrected", not "raw". Added a sysfs > > knob to allow you to read "raw", though. > > We could create an additional nvmem read-only provider in future if > required to read raw!. Makes sense. For

Re: [RFC v2 2/3] drivers: nvmem: Add QTI qfprom-efuse support

2020-06-15 Thread Srinivas Kandagatla
On 13/06/2020 21:33, Doug Anderson wrote: Hi, On Thu, Jun 11, 2020 at 2:49 AM Ravi Kumar Bokka wrote: This patch adds support for QTI qfprom-efuse controller. This driver can access the raw qfprom regions for fuse blowing. The current existed qfprom driver is only supports for cpufreq, th

Re: [RFC v2 2/3] drivers: nvmem: Add QTI qfprom-efuse support

2020-06-15 Thread Srinivas Kandagatla
I think Doug already covered most of the comments and his fixes seems be in right direction. On 11/06/2020 10:48, Ravi Kumar Bokka wrote: + qfpraw = platform_get_resource_byname(pdev, IORESOURCE_MEM, "raw"); + + priv->qfpraw = devm_ioremap_resource(dev, qfpraw); + if (IS_ER

Re: [RFC v2 2/3] drivers: nvmem: Add QTI qfprom-efuse support

2020-06-13 Thread Doug Anderson
Hi, On Thu, Jun 11, 2020 at 2:49 AM Ravi Kumar Bokka wrote: > > This patch adds support for QTI qfprom-efuse controller. This driver can > access the raw qfprom regions for fuse blowing. > > The current existed qfprom driver is only supports for cpufreq, thermal > sensors > drivers by read out c