Re: [RFC v2 23/24] m68k/mac: Fix PRAM accessors

2015-06-18 Thread Andreas Schwab
Finn Thain writes: > When I have reliable documentation I always define macros. So I agree that > "command" bytes like 0x34 and 0x3800 should have names but what are the > correct names? Are we constructing an opcode containing RTC register file > addresses or are we issuing read/write accesse

Re: [RFC v2 23/24] m68k/mac: Fix PRAM accessors

2015-06-17 Thread Geert Uytterhoeven
Hi Finn, On Thu, Jun 18, 2015 at 6:49 AM, Finn Thain wrote: > On Tue, 16 Jun 2015, in which I wrote: >> On Mon, 15 Jun 2015, Geert Uytterhoeven wrote: >> > More magic values... >> >> [...] The only useful RTC documentation I've ever come across is this: >> http://mac.linux-m68k.org/devel/plushw.p

Re: [RFC v2 23/24] m68k/mac: Fix PRAM accessors

2015-06-17 Thread Finn Thain
Hi Geert, Further to my previous email, On Tue, 16 Jun 2015, in which I wrote: > > On Mon, 15 Jun 2015, Geert Uytterhoeven wrote: > > > > > More magic values... > > [...] The only useful RTC documentation I've ever come across is this: > http://mac.linux-m68k.org/devel/plushw.php This doc

Re: [RFC v2 23/24] m68k/mac: Fix PRAM accessors

2015-06-15 Thread Finn Thain
On Mon, 15 Jun 2015, Geert Uytterhoeven wrote: > Hi Finn, > > On Sun, Jun 14, 2015 at 9:46 AM, Finn Thain > wrote: > > --- linux.orig/arch/m68k/mac/misc.c 2015-06-14 17:46:02.0 +1000 > > +++ linux/arch/m68k/mac/misc.c 2015-06-14 17:46:03.0 +1000 > > @@ -284,11 +287,31 @@ s

Re: [RFC v2 23/24] m68k/mac: Fix PRAM accessors

2015-06-15 Thread Geert Uytterhoeven
Hi Finn, On Sun, Jun 14, 2015 at 9:46 AM, Finn Thain wrote: > --- linux.orig/arch/m68k/mac/misc.c 2015-06-14 17:46:02.0 +1000 > +++ linux/arch/m68k/mac/misc.c 2015-06-14 17:46:03.0 +1000 > @@ -284,11 +287,31 @@ static void via_pram_command(int command > > static unsigned cha