Re: [RFC v2 PATCH 0/8] mm: mirrored memory support for page buddy allocations

2015-07-12 Thread Xishi Qiu
On 2015/6/30 19:53, Mel Gorman wrote: > On Tue, Jun 30, 2015 at 12:46:54PM +0200, Ingo Molnar wrote: >> >> * Mel Gorman wrote: >> >>> [...] >>> >>> Basically, overall I feel this series is the wrong approach but not knowing >>> who >>> the users are making is much harder to judge. I strongly su

RE: [RFC v2 PATCH 0/8] mm: mirrored memory support for page buddy allocations

2015-06-30 Thread Luck, Tony
> Sounds logical. In that case, bootmem awareness would be crucial. > Enabling support in just the page allocator is too late. Andrew already applied some patches from me that I think covered bootmem mirror allocations: commit fc6daaf93151877748f8096af6b3fddb147f22d6 mm/memblock: add extra "f

Re: [RFC v2 PATCH 0/8] mm: mirrored memory support for page buddy allocations

2015-06-30 Thread Mel Gorman
On Tue, Jun 30, 2015 at 12:46:54PM +0200, Ingo Molnar wrote: > > * Mel Gorman wrote: > > > [...] > > > > Basically, overall I feel this series is the wrong approach but not knowing > > who > > the users are making is much harder to judge. I strongly suspect that if > > mirrored memory is to

Re: [RFC v2 PATCH 0/8] mm: mirrored memory support for page buddy allocations

2015-06-30 Thread Ingo Molnar
* Mel Gorman wrote: > [...] > > Basically, overall I feel this series is the wrong approach but not knowing > who > the users are making is much harder to judge. I strongly suspect that if > mirrored memory is to be properly used then it needs to be available before > the > page allocator

Re: [RFC v2 PATCH 0/8] mm: mirrored memory support for page buddy allocations

2015-06-30 Thread Mel Gorman
On Sat, Jun 27, 2015 at 10:19:54AM +0800, Xishi Qiu wrote: > Intel Xeon processor E7 v3 product family-based platforms introduces support > for partial memory mirroring called as 'Address Range Mirroring'. This feature > allows BIOS to specify a subset of total available memory to be mirrored (and

Re: [RFC v2 PATCH 0/8] mm: mirrored memory support for page buddy allocations

2015-06-29 Thread Xishi Qiu
On 2015/6/30 9:52, Dave Hansen wrote: > On 06/29/2015 06:26 PM, Xishi Qiu wrote: Has there been any performance analysis done on this code? I'm always nervous when I see page_alloc.c churn. >> Not yet, which benchmark do you suggest? > > mmtests is always a good place to start. a

Re: [RFC v2 PATCH 0/8] mm: mirrored memory support for page buddy allocations

2015-06-29 Thread Dave Hansen
On 06/29/2015 06:26 PM, Xishi Qiu wrote: >> > Has there been any performance analysis done on this code? I'm always >> > nervous when I see page_alloc.c churn. >> > > Not yet, which benchmark do you suggest? mmtests is always a good place to start. aim9. I'm partial to will-it-scale. -- To u

Re: [RFC v2 PATCH 0/8] mm: mirrored memory support for page buddy allocations

2015-06-29 Thread Xishi Qiu
On 2015/6/29 23:19, Dave Hansen wrote: > On 06/26/2015 07:19 PM, Xishi Qiu wrote: >> drivers/base/node.c | 17 --- >> fs/proc/meminfo.c| 6 +++ >> include/linux/memblock.h | 29 ++-- >> include/linux/mmzone.h | 10 >> include/linux/vmstat.h | 2 + >> mm/Kc

Re: [RFC v2 PATCH 0/8] mm: mirrored memory support for page buddy allocations

2015-06-29 Thread Dave Hansen
On 06/26/2015 07:19 PM, Xishi Qiu wrote: > drivers/base/node.c | 17 --- > fs/proc/meminfo.c| 6 +++ > include/linux/memblock.h | 29 ++-- > include/linux/mmzone.h | 10 > include/linux/vmstat.h | 2 + > mm/Kconfig | 8 > mm/memblock.c