Re: [Sound-open-firmware] [PATCH v2 3/5] ASoC: SOF: Add DT DSP device support

2019-08-07 Thread Daniel Baluta
On Wed, Aug 7, 2019 at 6:28 PM Daniel Baluta wrote: > > On Wed, Aug 7, 2019 at 6:22 PM Pierre-Louis Bossart > wrote: > > > > > > +static int sof_dt_probe(struct platform_device *pdev) > > +{ > > + struct device *dev = &pdev->dev; > > + const struct sof_dev_desc *desc;

Re: [Sound-open-firmware] [PATCH v2 3/5] ASoC: SOF: Add DT DSP device support

2019-08-07 Thread Pierre-Louis Bossart
On 8/7/19 10:29 AM, Daniel Baluta wrote: On Tue, Jul 23, 2019 at 6:19 PM Pierre-Louis Bossart wrote: diff --git a/sound/soc/sof/Kconfig b/sound/soc/sof/Kconfig index 61b97fc55bb2..2aa3a1cdf60c 100644 --- a/sound/soc/sof/Kconfig +++ b/sound/soc/sof/Kconfig @@ -36,6 +36,15 @@ config SND_SOC

Re: [Sound-open-firmware] [PATCH v2 3/5] ASoC: SOF: Add DT DSP device support

2019-08-07 Thread Daniel Baluta
On Tue, Jul 23, 2019 at 6:19 PM Pierre-Louis Bossart wrote: > > > > diff --git a/sound/soc/sof/Kconfig b/sound/soc/sof/Kconfig > > index 61b97fc55bb2..2aa3a1cdf60c 100644 > > --- a/sound/soc/sof/Kconfig > > +++ b/sound/soc/sof/Kconfig > > @@ -36,6 +36,15 @@ config SND_SOC_SOF_ACPI > > Say

Re: [Sound-open-firmware] [PATCH v2 3/5] ASoC: SOF: Add DT DSP device support

2019-08-07 Thread Daniel Baluta
On Wed, Aug 7, 2019 at 6:22 PM Pierre-Louis Bossart wrote: > > > +static int sof_dt_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + const struct sof_dev_desc *desc; > + /*TODO: create a generic snd_soc_xxx_mach */ > +

Re: [Sound-open-firmware] [PATCH v2 3/5] ASoC: SOF: Add DT DSP device support

2019-08-07 Thread Pierre-Louis Bossart
+static int sof_dt_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + const struct sof_dev_desc *desc; + /*TODO: create a generic snd_soc_xxx_mach */ + struct snd_soc_acpi_mach *mach; I wonder if you really need to use the same structures. For Intel we

Re: [Sound-open-firmware] [PATCH v2 3/5] ASoC: SOF: Add DT DSP device support

2019-08-07 Thread Daniel Baluta
On Wed, Jul 24, 2019 at 10:04 AM Daniel Baluta wrote: > > On Tue, Jul 23, 2019 at 6:19 PM Pierre-Louis Bossart > wrote: > > > > > > > diff --git a/sound/soc/sof/Kconfig b/sound/soc/sof/Kconfig > > > index 61b97fc55bb2..2aa3a1cdf60c 100644 > > > --- a/sound/soc/sof/Kconfig > > > +++ b/sound/soc/so

Re: [Sound-open-firmware] [PATCH v2 3/5] ASoC: SOF: Add DT DSP device support

2019-07-24 Thread Daniel Baluta
On Tue, Jul 23, 2019 at 6:19 PM Pierre-Louis Bossart wrote: > > > > diff --git a/sound/soc/sof/Kconfig b/sound/soc/sof/Kconfig > > index 61b97fc55bb2..2aa3a1cdf60c 100644 > > --- a/sound/soc/sof/Kconfig > > +++ b/sound/soc/sof/Kconfig > > @@ -36,6 +36,15 @@ config SND_SOC_SOF_ACPI > > Say

Re: [Sound-open-firmware] [PATCH v2 3/5] ASoC: SOF: Add DT DSP device support

2019-07-23 Thread Pierre-Louis Bossart
diff --git a/sound/soc/sof/Kconfig b/sound/soc/sof/Kconfig index 61b97fc55bb2..2aa3a1cdf60c 100644 --- a/sound/soc/sof/Kconfig +++ b/sound/soc/sof/Kconfig @@ -36,6 +36,15 @@ config SND_SOC_SOF_ACPI Say Y if you need this option If unsure select "N". +config SND_SOC_SOF_DT