Re: [V3 PATCH 2/2] ASoC: max98390: Added Amplifier Driver

2020-05-14 Thread Steve Lee
On Thu, May 14, 2020 at 7:17 PM Mark Brown wrote: > > On Wed, May 13, 2020 at 07:58:12PM +0800, Tzung-Bi Shih wrote: > > On Wed, May 13, 2020 at 6:53 PM Mark Brown wrote: > > > On Wed, May 13, 2020 at 04:45:23PM +0900, Steve Lee wrote: > > > > > Changes since V2: > > > > * Removed warn mass

Re: [V3 PATCH 2/2] ASoC: max98390: Added Amplifier Driver

2020-05-14 Thread Mark Brown
On Wed, May 13, 2020 at 07:58:12PM +0800, Tzung-Bi Shih wrote: > On Wed, May 13, 2020 at 6:53 PM Mark Brown wrote: > > On Wed, May 13, 2020 at 04:45:23PM +0900, Steve Lee wrote: > > > Changes since V2: > > > * Removed warn massage in max98390_dsm_calib_get func > > > and add comment

Re: [V3 PATCH 2/2] ASoC: max98390: Added Amplifier Driver

2020-05-14 Thread Mark Brown
On Thu, May 14, 2020 at 03:31:52PM +0800, Tzung-Bi Shih wrote: > On Wed, May 13, 2020 at 3:47 PM Steve Lee wrote: > > +++ b/sound/soc/codecs/max98390.c > > @@ -0,0 +1,1030 @@ > > +// SPDX-License-Identifier: GPL-2.0-or-later > > +/* > > + * max98390.c -- MAX98390 ALSA Soc Audio driver > > + * >

Re: [V3 PATCH 2/2] ASoC: max98390: Added Amplifier Driver

2020-05-14 Thread Tzung-Bi Shih
On Wed, May 13, 2020 at 3:47 PM Steve Lee wrote: > +++ b/sound/soc/codecs/max98390.c > @@ -0,0 +1,1030 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +/* > + * max98390.c -- MAX98390 ALSA Soc Audio driver > + * > + * Copyright (C) 2020 Maxim Integrated Products > + * > + */ My previous co

Re: [V3 PATCH 2/2] ASoC: max98390: Added Amplifier Driver

2020-05-13 Thread Tzung-Bi Shih
On Wed, May 13, 2020 at 6:53 PM Mark Brown wrote: > > On Wed, May 13, 2020 at 04:45:23PM +0900, Steve Lee wrote: > > > Changes since V2: > > * Removed warn massage in max98390_dsm_calib_get func > > and add comment. > > The problem isn't the warning, the problem is that you have an e

Re: [V3 PATCH 2/2] ASoC: max98390: Added Amplifier Driver

2020-05-13 Thread Mark Brown
On Wed, May 13, 2020 at 04:45:23PM +0900, Steve Lee wrote: > Changes since V2: > * Removed warn massage in max98390_dsm_calib_get func > and add comment. The problem isn't the warning, the problem is that you have an empty operation. You should either implement the function (eg, b