Re: [Xen-devel] [PATCH V3 1/8] xen: Make functions static

2014-11-11 Thread Jürgen Groß
On 11/11/2014 11:50 AM, David Vrabel wrote: On 11/11/14 10:36, Juergen Gross wrote: On 11/11/2014 11:21 AM, David Vrabel wrote: On 11/11/14 05:43, Juergen Gross wrote: Some functions in arch/x86/xen/p2m.c are used locally only. Make them static. Rearrange the functions in p2m.c to avoid forwar

Re: [Xen-devel] [PATCH V3 1/8] xen: Make functions static

2014-11-11 Thread David Vrabel
On 11/11/14 10:36, Juergen Gross wrote: > On 11/11/2014 11:21 AM, David Vrabel wrote: >> On 11/11/14 05:43, Juergen Gross wrote: >>> Some functions in arch/x86/xen/p2m.c are used locally only. Make them >>> static. Rearrange the functions in p2m.c to avoid forward declarations. >>> >>> While at it

Re: [Xen-devel] [PATCH V3 1/8] xen: Make functions static

2014-11-11 Thread Juergen Gross
On 11/11/2014 11:21 AM, David Vrabel wrote: On 11/11/14 05:43, Juergen Gross wrote: Some functions in arch/x86/xen/p2m.c are used locally only. Make them static. Rearrange the functions in p2m.c to avoid forward declarations. While at it correct some style issues (long lines, use pr_warn()).

Re: [Xen-devel] [PATCH V3 1/8] xen: Make functions static

2014-11-11 Thread David Vrabel
On 11/11/14 05:43, Juergen Gross wrote: > Some functions in arch/x86/xen/p2m.c are used locally only. Make them > static. Rearrange the functions in p2m.c to avoid forward declarations. > > While at it correct some style issues (long lines, use pr_warn()). Please don't add extra stuff like this.