Re: [Xen-devel] [RFC v3 2/2] x86/xen: allow privcmd hypercalls to be preempted

2015-01-22 Thread Andrew Cooper
On 22/01/2015 20:58, Andy Lutomirski wrote: > On Thu, Jan 22, 2015 at 12:37 PM, Steven Rostedt wrote: >> On Thu, 22 Jan 2015 12:24:47 -0800 >> Andy Lutomirski wrote: >> Also, please remove the "notrace", because function tracing goes an extra step to not require RCU being visible. The o

Re: [Xen-devel] [RFC v3 2/2] x86/xen: allow privcmd hypercalls to be preempted

2015-01-22 Thread Andy Lutomirski
On Thu, Jan 22, 2015 at 1:16 PM, Steven Rostedt wrote: > On Thu, 22 Jan 2015 12:58:00 -0800 > Andy Lutomirski wrote: > >> On Thu, Jan 22, 2015 at 12:37 PM, Steven Rostedt wrote: >> > On Thu, 22 Jan 2015 12:24:47 -0800 >> > Andy Lutomirski wrote: >> >> >> >> >> The other issue, above and beyond

Re: [Xen-devel] [RFC v3 2/2] x86/xen: allow privcmd hypercalls to be preempted

2015-01-22 Thread Steven Rostedt
On Thu, 22 Jan 2015 12:58:00 -0800 Andy Lutomirski wrote: > On Thu, Jan 22, 2015 at 12:37 PM, Steven Rostedt wrote: > > On Thu, 22 Jan 2015 12:24:47 -0800 > > Andy Lutomirski wrote: > > > >> > Also, please remove the "notrace", because function tracing goes an > >> > extra step to not require R

Re: [Xen-devel] [RFC v3 2/2] x86/xen: allow privcmd hypercalls to be preempted

2015-01-22 Thread Paul E. McKenney
On Thu, Jan 22, 2015 at 03:16:57PM -0500, Steven Rostedt wrote: > > [ Added Paul McKenney ] > > On Thu, 22 Jan 2015 19:39:13 +0100 > "Luis R. Rodriguez" wrote: > > > > Why not make this a tracepoint? Then you can enable it only when you > > > want to. As tracepoints are also hooks, you could ad

Re: [Xen-devel] [RFC v3 2/2] x86/xen: allow privcmd hypercalls to be preempted

2015-01-22 Thread Andy Lutomirski
On Thu, Jan 22, 2015 at 12:37 PM, Steven Rostedt wrote: > On Thu, 22 Jan 2015 12:24:47 -0800 > Andy Lutomirski wrote: > >> > Also, please remove the "notrace", because function tracing goes an >> > extra step to not require RCU being visible. The only thing you get >> > with notrace is not being

Re: [Xen-devel] [RFC v3 2/2] x86/xen: allow privcmd hypercalls to be preempted

2015-01-22 Thread Steven Rostedt
On Thu, 22 Jan 2015 12:24:47 -0800 Andy Lutomirski wrote: > > Also, please remove the "notrace", because function tracing goes an > > extra step to not require RCU being visible. The only thing you get > > with notrace is not being able to trace an otherwise traceable function. > > > > Is this a

Re: [Xen-devel] [RFC v3 2/2] x86/xen: allow privcmd hypercalls to be preempted

2015-01-22 Thread Julien Grall
On 22/01/15 18:56, Luis R. Rodriguez wrote: > On Thu, Jan 22, 2015 at 01:10:49PM +, Julien Grall wrote: >> Hi Luis, >> >> On 22/01/15 02:17, Luis R. Rodriguez wrote: >>> diff --git a/drivers/xen/events/events_base.c >>> b/drivers/xen/events/events_base.c >>> index b4bca2d..23c526b 100644 >>> -

Re: [Xen-devel] [RFC v3 2/2] x86/xen: allow privcmd hypercalls to be preempted

2015-01-22 Thread Andy Lutomirski
On Thu, Jan 22, 2015 at 12:16 PM, Steven Rostedt wrote: > > [ Added Paul McKenney ] > > On Thu, 22 Jan 2015 19:39:13 +0100 > "Luis R. Rodriguez" wrote: > >> > Why not make this a tracepoint? Then you can enable it only when you >> > want to. As tracepoints are also hooks, you could add you own co

Re: [Xen-devel] [RFC v3 2/2] x86/xen: allow privcmd hypercalls to be preempted

2015-01-22 Thread Steven Rostedt
[ Added Paul McKenney ] On Thu, 22 Jan 2015 19:39:13 +0100 "Luis R. Rodriguez" wrote: > > Why not make this a tracepoint? Then you can enable it only when you > > want to. As tracepoints are also hooks, you could add you own code that > > hooks to it and does a printk as well. The advantage of

Re: [Xen-devel] [RFC v3 2/2] x86/xen: allow privcmd hypercalls to be preempted

2015-01-22 Thread Luis R. Rodriguez
On Thu, Jan 22, 2015 at 01:10:49PM +, Julien Grall wrote: > Hi Luis, > > On 22/01/15 02:17, Luis R. Rodriguez wrote: > > diff --git a/drivers/xen/events/events_base.c > > b/drivers/xen/events/events_base.c > > index b4bca2d..23c526b 100644 > > --- a/drivers/xen/events/events_base.c > > +++ b/

Re: [Xen-devel] [RFC v3 2/2] x86/xen: allow privcmd hypercalls to be preempted

2015-01-22 Thread Luis R. Rodriguez
On Thu, Jan 22, 2015 at 11:50:10AM +, Andrew Cooper wrote: > On 22/01/15 02:17, Luis R. Rodriguez wrote: > > --- a/drivers/xen/events/events_base.c > > +++ b/drivers/xen/events/events_base.c > > @@ -32,6 +32,8 @@ > > #include > > #include > > #include > > +#include > > +#include > > >

Re: [Xen-devel] [RFC v3 2/2] x86/xen: allow privcmd hypercalls to be preempted

2015-01-22 Thread Luis R. Rodriguez
On Thu, Jan 22, 2015 at 08:56:49AM -0500, Steven Rostedt wrote: > On Thu, 22 Jan 2015 11:50:10 + > Andrew Cooper wrote: > > > On 22/01/15 02:17, Luis R. Rodriguez wrote: > > > --- a/drivers/xen/events/events_base.c > > > +++ b/drivers/xen/events/events_base.c > > > @@ -32,6 +32,8 @@ > > > #i

Re: [Xen-devel] [RFC v3 2/2] x86/xen: allow privcmd hypercalls to be preempted

2015-01-22 Thread Luis R. Rodriguez
On Thu, Jan 22, 2015 at 12:55:17PM +, David Vrabel wrote: > On 22/01/15 03:18, Andy Lutomirski wrote: > >> --- a/drivers/xen/events/events_base.c > >> +++ b/drivers/xen/events/events_base.c > >> @@ -32,6 +32,8 @@ > >> #include > >> #include > >> #include > >> +#include > >> +#include >

Re: [Xen-devel] [RFC v3 2/2] x86/xen: allow privcmd hypercalls to be preempted

2015-01-22 Thread Steven Rostedt
On Thu, 22 Jan 2015 11:50:10 + Andrew Cooper wrote: > On 22/01/15 02:17, Luis R. Rodriguez wrote: > > --- a/drivers/xen/events/events_base.c > > +++ b/drivers/xen/events/events_base.c > > @@ -32,6 +32,8 @@ > > #include > > #include > > #include > > +#include > > +#include > > > > #

Re: [Xen-devel] [RFC v3 2/2] x86/xen: allow privcmd hypercalls to be preempted

2015-01-22 Thread Julien Grall
Hi Luis, On 22/01/15 02:17, Luis R. Rodriguez wrote: > diff --git a/drivers/xen/events/events_base.c > b/drivers/xen/events/events_base.c > index b4bca2d..23c526b 100644 > --- a/drivers/xen/events/events_base.c > +++ b/drivers/xen/events/events_base.c > @@ -32,6 +32,8 @@ > #include > #include

Re: [Xen-devel] [RFC v3 2/2] x86/xen: allow privcmd hypercalls to be preempted

2015-01-22 Thread David Vrabel
On 22/01/15 03:18, Andy Lutomirski wrote: >> --- a/drivers/xen/events/events_base.c >> +++ b/drivers/xen/events/events_base.c >> @@ -32,6 +32,8 @@ >> #include >> #include >> #include >> +#include >> +#include >> >> #ifdef CONFIG_X86 >> #include >> @@ -1243,6 +1245,17 @@ void xen_evtchn_d

Re: [Xen-devel] [RFC v3 2/2] x86/xen: allow privcmd hypercalls to be preempted

2015-01-22 Thread Andrew Cooper
On 22/01/15 02:17, Luis R. Rodriguez wrote: > --- a/drivers/xen/events/events_base.c > +++ b/drivers/xen/events/events_base.c > @@ -32,6 +32,8 @@ > #include > #include > #include > +#include > +#include > > #ifdef CONFIG_X86 > #include > @@ -1243,6 +1245,17 @@ void xen_evtchn_do_upcall