Re: [alsa-devel][PATCH 2/3] ASoC: fsl_sai: Add support for tdm slots operation

2015-01-23 Thread Nicolin Chen
On Fri, Jan 23, 2015 at 10:55:09AM +0800, Zidan Wang wrote: > I have another question. > > Can a channel have several slots? Or channel just means slot. Strictly speaking, a channel surely may have several slots IMO. The idea for TDM, even for I2S, left channel can bear multiple slots -- each may

Re: [alsa-devel][PATCH 2/3] ASoC: fsl_sai: Add support for tdm slots operation

2015-01-22 Thread Zidan Wang
On Thu, Jan 22, 2015 at 03:50:20PM -0800, Nicolin Chen wrote: > On Thu, Jan 22, 2015 at 02:20:06PM +0800, Zidan Wang wrote: > > > > > > @@ -369,10 +380,25 @@ static int fsl_sai_hw_params(struct > > > > > > snd_pcm_substream *substream, > > > > > > u32 word_width = snd_pcm_format_width(params_f

Re: [alsa-devel][PATCH 2/3] ASoC: fsl_sai: Add support for tdm slots operation

2015-01-22 Thread Nicolin Chen
On Thu, Jan 22, 2015 at 02:20:06PM +0800, Zidan Wang wrote: > > > > > @@ -369,10 +380,25 @@ static int fsl_sai_hw_params(struct > > > > > snd_pcm_substream *substream, > > > > > u32 word_width = snd_pcm_format_width(params_format(params)); > > > > > u32 val_cr4 = 0, val_cr5 = 0; > > >

Re: [alsa-devel][PATCH 2/3] ASoC: fsl_sai: Add support for tdm slots operation

2015-01-21 Thread Zidan Wang
On Wed, Jan 21, 2015 at 09:44:10PM -0800, Nicolin Chen wrote: > On Thu, Jan 22, 2015 at 12:55:35PM +0800, Zidan Wang wrote: > > On Wed, Jan 21, 2015 at 10:08:03AM -0800, Nicolin Chen wrote: > > > On Tue, Jan 20, 2015 at 08:21:19PM +0800, Zidan Wang wrote: > > > > @@ -369,10 +380,25 @@ static int fs

Re: [alsa-devel][PATCH 2/3] ASoC: fsl_sai: Add support for tdm slots operation

2015-01-21 Thread Nicolin Chen
On Thu, Jan 22, 2015 at 12:55:35PM +0800, Zidan Wang wrote: > On Wed, Jan 21, 2015 at 10:08:03AM -0800, Nicolin Chen wrote: > > On Tue, Jan 20, 2015 at 08:21:19PM +0800, Zidan Wang wrote: > > > @@ -369,10 +380,25 @@ static int fsl_sai_hw_params(struct > > > snd_pcm_substream *substream, > > > u3

Re: [alsa-devel][PATCH 2/3] ASoC: fsl_sai: Add support for tdm slots operation

2015-01-21 Thread Zidan Wang
On Wed, Jan 21, 2015 at 10:08:03AM -0800, Nicolin Chen wrote: > On Tue, Jan 20, 2015 at 08:21:19PM +0800, Zidan Wang wrote: > > @@ -369,10 +380,25 @@ static int fsl_sai_hw_params(struct snd_pcm_substream > > *substream, > > u32 word_width = snd_pcm_format_width(params_format(params)); > >

Re: [alsa-devel][PATCH 2/3] ASoC: fsl_sai: Add support for tdm slots operation

2015-01-21 Thread Nicolin Chen
On Tue, Jan 20, 2015 at 08:21:19PM +0800, Zidan Wang wrote: > @@ -369,10 +380,25 @@ static int fsl_sai_hw_params(struct snd_pcm_substream > *substream, > u32 word_width = snd_pcm_format_width(params_format(params)); > u32 val_cr4 = 0, val_cr5 = 0; > int ret; > + u32 bclk; > +