Re: [alsa-devel][PATCH v1] ASoC: TSCS454: Add Support

2018-05-30 Thread kbuild test robot
Hi Steven, I love your patch! Perhaps something to improve: [auto build test WARNING on asoc/for-next] [also build test WARNING on v4.17-rc7 next-20180530] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linu

Re: [alsa-devel][PATCH v1] ASoC: TSCS454: Add Support

2018-05-29 Thread Mark Brown
On Tue, May 29, 2018 at 05:52:00AM -0500, Steven Eckhoff wrote: > +static char const * const in_bst_txt[] = { > + "0 dB", "10 dB", "20 dB", "30 dB"}; > + This looks like just a regular volume control, it should be a normal SOC_SINGLE_TLV(). > + SOC_SINGLE("Input Channel 1 Mute En